Skip to content

fix(native-chat): repair main's web typecheck after the @-mention prop rename - #26097

Merged
Jinwoo-H merged 1 commit into
mainfrom
fix/composer-resume-test-mention-prop
Oct 7, 2026
Merged

Jinwoo-H merged 1 commit into
mainfrom
fix/composer-resume-test-mention-prop

Conversation

@Jinwoo-H

@Jinwoo-H Jinwoo-H commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​3 $\color{#cf222e}{\Huge{\mathbf{−}}}$​2 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​1
Prod 0 0 0 0

ELI5

Two native-chat PRs landed minutes apart. One renamed a composer property; the other added a test that still used the old name. Main no longer typechecks, so every open PR's "static analysis and typecheck" job is red. This updates the test.

What Changed

native-chat-composer-field-resume.test.tsx (as changed by #25835) still passed onAcceptMention and mocked NativeChatMentionHint. #26017 replaced those with onChooseMentionFile + mentionFiles and NativeChatMentionMenu, and updated every other composer test the same way. This test now matches. No product code changes.

Why

Same edit #26017 applied to its sibling tests, so the test fixture stays in step with the real props.

Linked Issue

N/A (main-wide typecheck break, seen on #26093).

Visual Proof

N/A, test-only change.

Testing

  • node config/scripts/run-typecheck-projects-in-parallel.mjs (all projects) clean on this branch.

  • The test file passes (7/7). oxlint / oxfmt clean.

  • I manually tested these changes locally

  • Automated tests added/updated, or explained why not below

Before/after qualification

Measurement Before After Improvement
Web typecheck 1 TS2322 error for the removed mention prop 0 errors; full Node/CLI/web typecheck passes Clears the compile blocker
Original runtime cases 7 passed under Bun 7 passed under Bun and 7 under stock Node Exact case names/statuses retained
Assertion sites 12 12 All assertions preserved

Before compile failure: PR #26095 CI. After qualification used the exact merged fixture bytes from c8dcffce46d9 on integrated head 80f072895284, on macOS with background launches. The full seven-case definition region is byte-identical to the pre-fix fixture; only the fixture inputs/mock changed. This is a correctness repair, with no speed claim.

Review

Agent skill upstream boundary

  • Not applicable

Notes

Test-only.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • N/A for visuals with reason
  • Self-reviewed for correctness, security, and performance
  • Cross-platform, SSH/remote, and path/shortcut impact considered
  • CI will cover lint/typecheck/test/build

…e test

#25835 kept the onAcceptMention prop that #26017 replaced with
onChooseMentionFile and mentionFiles, so the web typecheck fails on main.
@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: bd96cfac-a7c9-4ee5-9eb2-9a5bffc55e00
📥 Commits

Reviewing files that changed from the base of the PR and between a3ecee0 and cc64162.

📒 Files selected for processing (1)
  • src/renderer/src/components/native-chat/native-chat-composer-field-resume.test.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

The resume test mock now provides NativeChatMentionMenu instead of NativeChatMentionHint. The composer fixture now provides onChooseMentionFile and an empty, non-loading, non-failed mentionFiles value instead of onAcceptMention.

Priority: ➖ Normal

Merge Risk: ⚪ Minimal · up to cc641

This test-only update preserves its resume, send/stop, focus, and disabled checks while matching the current component API. No actionable merge risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the native-chat typecheck fix and the @-mention prop rename.
Description check ✅ Passed The description explains the change, its reason, and testing. It also marks visual proof as N/A with a reason. The linked issue is marked N/A with an explanation, and the AI Disclosure section is blan…
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Jinwoo-H
Jinwoo-H merged commit c8dcffc into main Oct 7, 2026
30 checks passed
brennanb2025 added a commit that referenced this pull request Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant