Repository navigation
fix(native-chat): repair main's web typecheck after the @-mention prop rename - #26097
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe resume test mock now provides Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to This test-only update preserves its resume, send/stop, focus, and disabled checks while matching the current component API. No actionable merge risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ELI5
Two native-chat PRs landed minutes apart. One renamed a composer property; the other added a test that still used the old name. Main no longer typechecks, so every open PR's "static analysis and typecheck" job is red. This updates the test.
What Changed
native-chat-composer-field-resume.test.tsx(as changed by #25835) still passedonAcceptMentionand mockedNativeChatMentionHint. #26017 replaced those withonChooseMentionFile+mentionFilesandNativeChatMentionMenu, and updated every other composer test the same way. This test now matches. No product code changes.Why
Same edit #26017 applied to its sibling tests, so the test fixture stays in step with the real props.
Linked Issue
N/A (main-wide typecheck break, seen on #26093).
Visual Proof
N/A, test-only change.
Testing
node config/scripts/run-typecheck-projects-in-parallel.mjs(all projects) clean on this branch.The test file passes (7/7). oxlint / oxfmt clean.
I manually tested these changes locally
Automated tests added/updated, or explained why not below
Before/after qualification
Before compile failure: PR #26095 CI. After qualification used the exact merged fixture bytes from
c8dcffce46d9on integrated head80f072895284, on macOS with background launches. The full seven-case definition region is byte-identical to the pre-fix fixture; only the fixture inputs/mock changed. This is a correctness repair, with no speed claim.Review
Agent skill upstream boundary
Notes
Test-only.
Checklist
N/Afor visuals with reason