Skip to content

test(orchestration): give the stopping-worker task guard a Run (fixes main shard 3/8) #19571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nwparker wants to merge 2 commits into from
Closed

test(orchestration): give the stopping-worker task guard a Run (fixes main shard 3/8) #19571

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e958ae5
test(orchestration): give the stopping-worker task guard a Run
nwparker Sep 8, 2026
195760d
Merge origin/main (picks up #19566 so CI validates against a base who…
nwparker Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/runtime/orchestration/db-stopping-worker-task-guard.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ describe('a Task whose supervised worker is stopping', () => {
afterEach(() => db.close())

function localWorker() {
const task = db.createTask({ spec: 'local work' })
const task = db.createTask({ runId: 'run_legacy_local', spec: 'local work' })

@nwparker nwparker Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks — correct, and the PR body is fixed: create-core-tables-sql.ts only supplies the column DEFAULT; the run_legacy_local row itself is inserted by migrate-v2-v12.ts (INSERT OR IGNORE INTO runs) during schema setup, which is why requireRun passes on a fresh :memory: db.

const { dispatch } = db.createStartingWorkerDispatch({
taskId: task.id,
startOptions: {},
Expand Down Expand Up @@ -59,7 +59,7 @@ describe('a Task whose supervised worker is stopping', () => {
})

it('control: still accepts dispatched for an active Dispatch with no supervised worker', () => {
const task = db.createTask({ spec: 'unsupervised work' })
const task = db.createTask({ runId: 'run_legacy_local', spec: 'unsupervised work' })
createRootDispatch(db, task.id, 'term_worker')

expect(db.updateTaskStatus(task.id, 'dispatched')?.status).toBe('dispatched')
Expand Down
Loading