Repository navigation
fix(terminal): refuse to submit a CLI prompt over an unsent composer draft #16290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
luisgonzaleznf
wants to merge
20
commits into
stablyai:main
Choose a base branch
from
luisgonzaleznf:fix/terminal-send-pending-draft
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+732
−75
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
d387cf3
fix(terminal): refuse to submit a CLI prompt over an unsent composer …
luisgonzaleznf 0c33381
fix(terminal): harden the pending-draft guard against dialogs and lon…
luisgonzaleznf 100a179
Merge origin/main into fix/terminal-send-pending-draft
luisgonzaleznf ee4965c
fix(terminal): use evidence, not text prefixes, for composer boundaries
luisgonzaleznf dc9bbe9
chore: drop pre-commit re-indent of an unrelated test
luisgonzaleznf 4ed4064
chore: drop pre-commit reformatting of files untouched by this change
luisgonzaleznf 1c5cba7
Merge origin/main into fix/terminal-send-pending-draft
luisgonzaleznf 8621757
fix(terminal): tell a dialog from a draft by cursor visibility, not r…
luisgonzaleznf 08003a1
Merge origin/main into fix/terminal-send-pending-draft
luisgonzaleznf 4d6692f
Merge origin/main into fix/terminal-send-pending-draft
luisgonzaleznf d80e6cc
fix(terminal): accept a labelled composer frame line when detecting d…
luisgonzaleznf 893909e
Merge remote-tracking branch 'origin/main' into fix/terminal-send-pen…
luisgonzaleznf 324bc51
fix(terminal): corroborate a labelled composer frame and recheck the …
luisgonzaleznf 61e09c2
Merge remote-tracking branch 'origin/main' into fix/terminal-send-pen…
luisgonzaleznf aa27734
test(terminal): pass the input kind main now requires on agent-prompt…
luisgonzaleznf 3522f39
Merge remote-tracking branch 'origin/main' into fix/terminal-send-pen…
luisgonzaleznf edd0aa8
Merge remote-tracking branch 'origin/main' into fix/terminal-send-pen…
luisgonzaleznf aba267d
Merge remote-tracking branch 'origin/main' into fix/terminal-send-pen…
luisgonzaleznf 4f76634
fix(terminal): re-read the composer after upstream's beforeWrite wrapper
luisgonzaleznf d06d755
fix(terminal): assert writability after the composer read, not before it
luisgonzaleznf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: stablyai/orca
Length of output: 41492
Script executed:
Repository: stablyai/orca
Length of output: 41468
Script executed:
Repository: stablyai/orca
Length of output: 24200
Document Git publisher normalization in the manifest reference.
The runtime already converts Git owners such as
john.doe__xtojohn-doe-x. Update the manifest-reference generator text insrc/shared/plugins/manifest/plugin-manifest.tsto describe this rule and include an example, then regeneratedocs/reference/plugin-manifest.md.