Repository navigation
Conversation
Contributor
|
Closing this submitted branch and routing the heartbeat wake-suppression bug to canonical issue #14910. Newer owner PR #15173 covers the same wake half together with the required heartbeat-read surface; we will own the final current-main implementation there. Full credit to @portrah is preserved. No action is requested from you. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Heartbeat-only traffic currently starts coordinator turns and accumulated heartbeats can inflate a later wake batch. Heartbeats already update dispatch liveness during lifecycle reconciliation, so they do not need to wake an idle coordinator.
Verification
pnpm exec vitest run --config config/vitest.config.ts src/main/runtime/orca-runtime.test.ts(1074 passed, 1 skipped)pnpm run typecheckpnpm exec oxlint src/main/runtime/orchestration/db.ts src/main/runtime/orca-runtime.ts src/main/runtime/orca-runtime.test.ts