Skip to content

[Bug]: the main-process sync-launch ratchet check crashes on main (stale imports after #27788) #28052

Closed

Description

@adifsgaid

Operating system

macOS

Orca version

main at a940929

Details

Short summary:
pnpm run check:main-sync-spawn-ratchet throws on import on current main. That also fails audit:code-quality:native, pnpm lint, and the "Check main-process sync launches" step in pr.yml.

What happened?

$ node config/scripts/check-main-sync-spawn-ratchet.mjs
SyntaxError: The requested module './check-focus-read-ratchet.mjs' does not provide an export named 'diffCounts'

The script (#27756) imports diffCounts, formatBaseline, parseBaseline and parseBaselineNotes from check-focus-read-ratchet.mjs. #27788 had already moved those helpers into ratchet-baseline.mjs (as diffCounts, formatCountBaseline, parseCountBaseline, parseCountNotes) about twelve hours earlier, so the two PRs crossed.

How can we reproduce it?

  1. Check out main (a940929).
  2. Run pnpm run check:main-sync-spawn-ratchet, or pnpm lint.

Anything else that might help:
Once the imports are fixed, the ratchet reports three baseline mismatches the crash was hiding:

I ran into this while running the PR checks locally for #28044. I have a small fix ready and will open a PR right after this: the imports, the script's own --prune, and the two missing rows in a separate commit in case you'd rather convert those two launches to runProcess instead.

cc @brennanb2025 @OrcaWin

Activity

  1. AmethystLiang commented on Oct 12, 2026

    @AmethystLiang
    Contributor

    Thanks for reporting. Looking into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

os:macosIssues affecting macOS

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions