feat(visualize): add a D2 emitter behind the graph emitter seam#558
Draft
joshua-temple wants to merge 2 commits into
Draft
feat(visualize): add a D2 emitter behind the graph emitter seam#558joshua-temple wants to merge 2 commits into
joshua-temple wants to merge 2 commits into
Conversation
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
cascade graphrenders only Mermaid. A high-fidelity, branded rendering path (the crucible teal-dark style) needs D2 source as its boundary, emitted by the main binary so a sidecar renderer can turn it into SVG or PNG.Fix
Add a
D2Emitterbehind the existingvisualize.Emitterseam and select it withcascade graph --format d2. It is stdlib-only string generation (no D2 dependency in the main binary), mirroring the Mermaid emitter:Verification
graph --format d2command tests, including the JSON envelope and cross-repo lanes.58-graph-d2-renderexercisescascade graph --format d2end to end (deterministic source, read-only).go build ./...,go test ./..., andgolangci-lint run ./...clean on both the root ande2emodules.Draft: opened for maintainer review. Sidecar binary, ephemeral install, and release publishing are intentionally out of scope here.