Harden CI and modernize pnpm toolchain (corepack + pnpm 11)#733
Open
stabbylambda wants to merge 2 commits into
Open
Harden CI and modernize pnpm toolchain (corepack + pnpm 11)#733stabbylambda wants to merge 2 commits into
stabbylambda wants to merge 2 commits into
Conversation
Replace languages.javascript.pnpm.enable with corepack.enable in devenv.nix and add packageManager "pnpm@11.5.2" to the root package.json so pnpm 11 is used consistently locally and in CI. Lockfile remains lockfileVersion 9.0. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pin every action to a commit SHA with a version comment, add job timeout-minutes, and add a standard concurrency group to the Rust workflow. The deploy workflow keeps its dedicated serialized "deploy" concurrency group (cancel-in-progress: false) and remains gated to push/main + workflow_dispatch, so it does not run on pull requests. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modernizes the toolchain and hardens GitHub Actions workflows, matching the treatment applied to sibling repos.
pnpm → corepack + pnpm 11
devenv.nix: replacedlanguages.javascript.pnpm.enable = truewithlanguages.javascript.corepack.enable = true.package.json: pinned"packageManager": "pnpm@11.5.2".pnpm install --lockfile-only); it stays atlockfileVersion: '9.0'with no content changes.Build allowlist — N/A
pnpm-workspace.yamlhas noallowBuilds/onlyBuiltDependencies/settingsconfig, and an empiricalCI=true pnpm install --frozen-lockfileproduced noERR_PNPM_IGNORED_BUILDS. Left as-is.CI workflow hardening (
deploy.yml,rust.yml)# vX.Y.Zcomment (checkout, install-nix-action, cachix-action, configure-aws-credentials).timeout-minutes: 30to every job.rust.yml.deploy.ymlkeeps its dedicated serializeddeploygroup (cancel-in-progress: false).deploy.ymlremains gated to push/main +workflow_dispatch, so it is skipped on PRs (expected).These workflows use the devenv-shell pattern rather than
setup-node/pnpm/action-setup, so the pnpm-store cache reordering items from the playbook do not apply. No Dockerfile and no Vite config exist, so those items are N/A.Validation
actionlintpasses on both workflows with no warnings.CI=true pnpm install --frozen-lockfileand--ignore-scriptsboth succeed.🤖 Generated with Claude Code