Load multisig RPC configuration from environment - F-ssv-dkg-009 - #238
Open
julienharbulot wants to merge 3 commits into
Open
Load multisig RPC configuration from environment - F-ssv-dkg-009#238julienharbulot wants to merge 3 commits into
julienharbulot wants to merge 3 commits into
Conversation
nkryuchkov
previously approved these changes
Apr 23, 2026
ljuba-ssv
previously approved these changes
Apr 24, 2026
julienharbulot
dismissed stale reviews from ljuba-ssv and nkryuchkov
via
April 28, 2026 06:41
d36265e
ljuba-ssv
previously approved these changes
Apr 29, 2026
nkryuchkov
previously approved these changes
Apr 29, 2026
momosh-ssv
self-requested a review
April 30, 2026 07:45
momosh-ssv
reviewed
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
F-ssv-dkg-009This fixes a security finding in
ssv-dkgwhere an Alchemy Sepolia API key was hardcoded inintegration_test/multisig_test.goand the Gnosis multisig example scripts underutils/gnosis_multisig_examples.Changes
ETH_RPC_URLand skip the RPC-dependent tests when it is not set..gitignoreto ignore*.envfiles.Validation
GOPROXY=https://proxy.golang.org,direct go test -timeout=3600s ./integration_test/... -run 'Test(ReshareBulkJSONPArsing|ResignBulkJSONPArsing|VerifyMultisigSignedOnChain2of3|VerifyMultisigSignedOnChain|VerifyMultisigSignedOffChain|VerifyEOASigned)$'GOPROXY=https://proxy.golang.org,direct go tool golangci-lint run -v ./integration_test/...Fixes - Fixes ssvlabs/ssv-node-board#623