fix(brains): correct the brains-integrations skill to the real MCP surface [BRNS-CORE-058] - #26
Merged
Merged
Conversation
…rface The skill claimed there was no MCP tool to enumerate the catalog and implied the uninstall cascade was web-only. Both are false: list_recipes (with tier/kind/category/q), recommend_recipes, list_installed_versions and preview_uninstall_recipe -> uninstall_recipe all exist today. Adds the install-tuning tools (set_integration_config, set_integration_overrides, run_integration_once) and a new authoring section routing recipe publication through the create_integration_flow playbook rather than restating the IntegrationTemplate spec. Corrects claims that had gone stale: source enums are advertised statically and enforced at call time, not filtered per user; list_my_integrations no longer returns cost; bundle cascades run over MCP; integration installs are revoked outright rather than entering the 7-day recovery window; and install_recipe is not an upgrade path, since a re-apply advances the provenance stamp without bringing the entity's content along.
stefan-ssv-labs
approved these changes
Aug 10, 2026
stefan-ssv-labs
left a comment
stefan-ssv-labs
left a comment
Contributor
There was a problem hiding this comment.
✅ review-pr: clean vs BRNS-CORE-058.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this delivers
The hand-authored brains-integrations skill taught a stale surface: "no MCP tool to enumerate the catalog", web-only uninstall cascades, no authoring story. This rewrites it against what actually ships — catalog browsing (
list_recipestiers +recommend_recipes), version-drift reading (list_installed_versionsas a provenance stamp, with its limits stated), the MCP uninstall cascade (preview_uninstall_recipe→uninstall_recipe, with the integration-install recovery exception), install tuning (set_integration_config,set_integration_overrides,run_integration_once), and an authoring section (create_integration_flowplaybook →publish_recipe/ publisher management). Version 2.8.2 → 2.8.3 in both manifests — hosts update on version, so the bump is the delivery.Closes BRNS-CORE-058 (the unsuperseded brains-integrations half of #10).
Beyond the #10 port
Every claim was re-verified against ssvlabs/brains at current main/stage (all cited files byte-identical on both refs). Where #10 or the current file disagreed with the code, the code won: #10's description contained a frontmatter-breaking colon (it would have shipped a skill with empty metadata), "pluginOnly = this surface and nowhere else" (the gate blocks only web-agent/Telegram), "everything lands in 7-day recovery" (integration uninstall is a one-shot revoke), "catalog = curated" (it is everything publicly published;
owner_user_id: nullmarks the curated rows), the per-kind upgrade routing including the standalone leaf-upgrade fallback, unavailable sources returning success-shaped no-ops rather than errors, and re-apply semantics (provenance + automation state + un-customized dashboard only).Verification
Contract suite green with a real
claude plugin validate --strict(ran, not skipped); delivery guard passes 2.8.2 → 2.8.3; frontmatter parsed standalone; trigger-owner sweep clean. Three independent review passes on the committed diff (adversarial, standard, fresh-context verifier) — every finding addressed or refuted with evidence.Careful-review callout: this file is a prompt agents execute on user machines — every behavioral sentence is load-bearing.