Skip to content

docs: the Windows tests that ran nowhere now gate, and one still does not - #66

Merged
Amir-SSVLabs merged 1 commit into
devfrom
docs/windows-tests-now-gate
Aug 13, 2026
Merged

docs: the Windows tests that ran nowhere now gate, and one still does not#66
Amir-SSVLabs merged 1 commit into
devfrom
docs/windows-tests-now-gate

Conversation

@Amir-SSVLabs

Copy link
Copy Markdown
Contributor

Follow-up to #62, which merged an hour ago. Two files, comments only, no behaviour change.

The note that is now false

src-tauri/src/resources.rs said its two #[cfg(windows)] tests do not run in CI, and named what would change that: "the windows CI job compiling THIS crate". #62 is that change. browser_host.rs's ungated ns_window() is gated, so brains-desktop links on Windows, and the rust matrix runs cargo test --workspace — which includes this crate.

The note therefore now says the opposite of the truth and points the reader at a job that no longer exists (#45's separate Windows (recording) job, removed in #62's merge).

Rewritten with evidence instead of inference, from the Windows leg's own log on #62's run:

test resources::tests::a_verbatim_resource_dir_loses_its_prefix_before_reaching_node ... ok
test resources::tests::a_genuine_unc_path_is_left_alone ... ok

That is the regression coverage for the verbatim-path bug finally executing on the only platform where it can fail. The same note also claimed cargo test -p brains-desktop resources could not be run on Windows at all — it now passes locally there too (3 passed).

The #[cfg(windows)] gate stays, and the note keeps saying why: dunce::simplified is the identity function off Windows, so the assertions cannot hold there, and making them platform-free would mean asserting against a reimplementation of dunce rather than the code that ships.

The gap #62 exposes rather than creates

Recorded in the recording engine's README beside the other open Windows items: tests/fake_sidecar.rs is #![cfg(unix)], so the Windows leg runs 0 of its 4 tests while covering everything else in the crate. It was invisible while no Windows leg existed.

Worth naming for what it leaves unpinned there: the one-shot window-peak contract — whose breakage is what made micDeviceMismatch dead on every platform — is proven today only on macOS and in jsdom. Porting the fake from a shell script to Node would close it. Not done here; it is a real change, not a comment.

Why bother with a comments-only PR

Because a comment that misdirects is worse than no comment, and this one tells the next person to widen a job that is gone. Rule 4 of CLAUDE.md treats these headers as contracts.

Gates

npm run lint:size green · cargo test -p brains-desktop resources 3 passed on Windows 11 · no code touched, so nothing else can move.

🤖 Generated with Claude Code

… not

`resources.rs` carried a note saying its two `#[cfg(windows)]` tests did not
run in CI, and it named what would change that: "the windows CI job compiling
THIS crate". #62 is that change — `browser_host.rs`'s ungated `ns_window()` is
gated, so `brains-desktop` links on Windows, and the `rust` matrix runs
`cargo test --workspace`, which includes this crate.

So the note now says the opposite of the truth, and points at a job that no
longer exists. Rewritten with the evidence rather than the inference — from the
Windows leg's own log:

  test resources::tests::a_verbatim_resource_dir_loses_its_prefix_before_reaching_node ... ok
  test resources::tests::a_genuine_unc_path_is_left_alone ... ok

That is the regression coverage for the verbatim-path bug finally executing on
the only platform where it can fail. The same note claimed `cargo test -p
brains-desktop resources` could not be run on Windows at all; it now passes
locally there too (3 passed).

The `#[cfg(windows)]` gate itself stays, and the note keeps saying why:
`dunce::simplified` is the identity function off Windows, so the assertions
cannot hold there, and making them platform-free would mean asserting against
a reimplementation of dunce instead of the code that ships.

Also records the gap #62 exposes rather than creates, in the recording engine's
README beside the other open Windows items: `tests/fake_sidecar.rs` is
`#![cfg(unix)]`, so the Windows leg runs 0 of its 4 tests while covering
everything else in the crate. Worth naming because of what it leaves unpinned
there — the one-shot window-peak contract, whose breakage made
`micDeviceMismatch` dead on every platform, is proven today only on macOS and
in jsdom.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@Amir-SSVLabs
Amir-SSVLabs merged commit f5e78e6 into dev Aug 13, 2026
7 checks passed
@Amir-SSVLabs
Amir-SSVLabs deleted the docs/windows-tests-now-gate branch August 13, 2026 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant