Update sqs-consumer and sqs-producer to fix graceful shutdown - #83
Conversation
|
I'm sorry for the very late response. I've now merged this PR and I really appreciate your contribution. This will be included in the next major release, which will drop support for Node.js v16. |
|
Great to see this get merged. Just so you're aware, there is a potential memory leak caused by one of the dependencies of sqs-consumer V10. They bumped the dependency version in v11 to ensure the fix. It would be great to bump to v11 now. |
Thanks for letting me know. I’ll update it very soon, nearly right after my current work. |
FYI: I'm preparing the next release in #85. |
Processes in progress are being interrupted before being completed by the Kubernetes deployment or downscale process.
The SQS Consumer and SQS Producer libs already correct this problem. When
.stop()is invoked, these libs are already programmed to wait for ongoing processes to finish.