Skip to content

Update sqs-consumer and sqs-producer to fix graceful shutdown - #83

Merged
ssut merged 5 commits into
ssut:masterfrom
eduardoazevedo3:feat/update-sqs-consumer-and-producer
Jul 12, 2024
Merged

Update sqs-consumer and sqs-producer to fix graceful shutdown#83
ssut merged 5 commits into
ssut:masterfrom
eduardoazevedo3:feat/update-sqs-consumer-and-producer

Conversation

@eduardoazevedo3

Copy link
Copy Markdown
Contributor

Processes in progress are being interrupted before being completed by the Kubernetes deployment or downscale process.

The SQS Consumer and SQS Producer libs already correct this problem. When .stop() is invoked, these libs are already programmed to wait for ongoing processes to finish.

@ssut
ssut merged commit 956d052 into ssut:master Jul 12, 2024
@ssut

ssut commented Jul 12, 2024

Copy link
Copy Markdown
Owner

I'm sorry for the very late response. I've now merged this PR and I really appreciate your contribution. This will be included in the next major release, which will drop support for Node.js v16.

@cpt-pete

Copy link
Copy Markdown

@ssut

Great to see this get merged.

Just so you're aware, there is a potential memory leak caused by one of the dependencies of sqs-consumer V10. They bumped the dependency version in v11 to ensure the fix.

It would be great to bump to v11 now.

bbc/sqs-consumer#509

@ssut

ssut commented Jul 12, 2024

Copy link
Copy Markdown
Owner

@ssut

Great to see this get merged.

Just so you're aware, there is a potential memory leak caused by one of the dependencies of sqs-consumer V10. They bumped the dependency version in v11 to ensure the fix.

It would be great to bump to v11 now.

bbc/sqs-consumer#509

Thanks for letting me know. I’ll update it very soon, nearly right after my current work.

@ssut

ssut commented Jul 12, 2024

Copy link
Copy Markdown
Owner

@ssut

Great to see this get merged.

Just so you're aware, there is a potential memory leak caused by one of the dependencies of sqs-consumer V10. They bumped the dependency version in v11 to ensure the fix.

It would be great to bump to v11 now.

bbc/sqs-consumer#509

FYI: I'm preparing the next release in #85.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants