fix: dispatch handlers via live lookup instead of .bind() snapshot - #109
Open
bro-ankit wants to merge 1 commit into
Open
fix: dispatch handlers via live lookup instead of .bind() snapshot#109bro-ankit wants to merge 1 commit into
bro-ankit wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #108 —
SqsServicebinds@SqsMessageHandler/@SqsConsumerEventHandlermethods via.bind()atonModuleInit, capturing a frozen snapshot of the method at that exact moment. Any provider that wraps a decorated method after that point — a standard Nest extension pattern (see@golevelup/nestjs-discovery's own docs, which cite@nestjs/graphql's@Mutation/@Resolverdiscovery as the reference example) — has that wrapping silently ignored for SQS-bound handlers. The message still processes (nothing crashes), but any cross-cutting logic layered on top never fires. No error, no warning.This isn't a contrived timing edge case:
onModuleInitruns strictly beforeonApplicationBootstrapfor the entire application, across every module, regardless of import order. Any executor usingOnApplicationBootstrap(a common choice, since it's guaranteed to run after allonModuleInithooks) hits this on every SQS handler, unconditionally.Fix
Replaced the
.bind()capture (handleMessage,handleMessageBatch, event listener) with a closure that looks upinstance[methodName]at call time: