Add setup_python_venv function - #1245
Conversation
|
I encountered similar errors. By installing sympy we enable the polarfly/polarstar tests, which then fail on macOS. I found the root cause, which turns out to be macOS-CI-specific problem. The polarfly/polarstar python topology generators write their adjacency list to os.getcwd()/topo_data/ and the C++ topology components read it back. On the macOS runner the working directory isn't writable. I have a tested a fix in sst-elements that changes the write directory the to a tempfile.mkdtemp(). I can create a pull request if we don't want these tests skipped on macOS. I'm not sure if we'd rather have the CI continue to skip the these tests? -- it we want to skip the tests we just don't install sympy on macOS. |
Yeah, let's go that route. Let me know when that PR is available so we can get it merged quickly. Then we can continue with this change. |
|
The elements PR went through, this should pass testing now. |
|
Seems the issue is now related to the bamboo.sh not putting the site-packages on the PYTHONPATH (in addition to the activation path).
Confirmed locally on macOS: SST's sstsim.x embedded Python doesn't pick up the venv via activation (sys.prefix stays at the base python), so import sympy fails in the simulation subprocess → polarfly/polarstar construction aborts → empty output. Putting the venv site-packages on PYTHONPATH fixes it. Not sure why we see this on mac, but not Linux though. |
|
I can confirm that I don't see this on Linux but do on macOS. I would like to understand why. |
|
It looks like my addition of |
|
It's failing in Jenkins because of |
59f8cbf to
3f81a18
Compare
|
Current status is basically the last two comments:
Next steps:
|
|
3f81a18 to
85038e5
Compare
5bb2e9b to
6920fb9
Compare
Co-authored-by: Eric Berquist <727571+berquist@users.noreply.github.com>
Co-authored-by: Eric Berquist <727571+berquist@users.noreply.github.com>
In this case that's SST_PYTHON_APP_EXE.
Remove commented code.
a0d6826 to
601e477
Compare
No description provided.