Shmem sirius trace - #2717
Closed
Pawan-Kumar-HPLabs wants to merge 4 commits into
Closed
Conversation
- Removed a call to Output object in a destructor that could cause segfaults on shutdown. Fixes sstsimulator#2703 - Updated some printf format flags to use PRI versions
It does not return consistent results
The removed variable "id" is not set in the typical constructor but then used in setup() - we suspect this is causing issues with our internal testing of mordred. Since this variable appears to have been replaced by "net_id" we have removed it from the nic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Erase this information and put your Pull Request comments here
Instructions for Issuing a Pull Request to sst-elements
1 - Verify that the Pull Request is targeted to the devel branch of sstsimulator/sst-elements
2 - Verify that Source branch is up to date with the devel branch of sst-elements
3 - After submitting your Pull Request:
4 - DO NOT DELETE THE BRANCH (OR FORKED REPO) UNTIL THE PULL REQUEST IS MERGED.