Skip to content

Pr1 nic flowkey - #2696

Closed
nab880 wants to merge 105 commits into
sstsimulator:develfrom
nab880:pr1-nic-flowkey
Closed

Pr1 nic flowkey#2696
nab880 wants to merge 105 commits into
sstsimulator:develfrom
nab880:pr1-nic-flowkey

Conversation

@nab880

@nab880 nab880 commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

This fixes an edge case bug where the completionQueue would interleave messages if there is a flowId collision.

flowId is only unique per sender. When there are many senders and one receiver collisions can occur. Different sources packets get reassembled in the same slot.

The fix was to add a recvCqFlowKey that packs source into the top 16 bits and flowId into the lower 48 bits to avoid collisions.

sst-autotester and others added 30 commits August 17, 2023 07:57
@sst-autotester
Merge pull request sstsimulator#2204 from sstsimulator/devel
1e8894c 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2206 from sstsimulator/devel
72f5867 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2212 from sstsimulator/devel
c83f878 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2215 from sstsimulator/devel
9b2e8aa 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2217 from sstsimulator/devel
334ce4e 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2222 from sstsimulator/devel
f5c9109 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2228 from sstsimulator/devel
21a495d 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2231 from sstsimulator/devel
5cc3503 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2237 from sstsimulator/devel
35d6ec7 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2245 from sstsimulator/devel
2bffcee 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2246 from sstsimulator/devel
d8a9ca8 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2254 from sstsimulator/devel
22276fe 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2259 from sstsimulator/devel
4c43f48 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2262 from sstsimulator/devel
ebee81a 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2267 from sstsimulator/devel
a4561e3 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2272 from sstsimulator/devel
64ba3f8 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2279 from sstsimulator/devel
7e3c94a 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2281 from sstsimulator/devel
03a13c0 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2292 from sstsimulator/devel
bce52e3 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2295 from sstsimulator/devel
0011cc7 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2298 from sstsimulator/devel
a0d0980 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2301 from sstsimulator/devel
aa9d85a 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2303 from sstsimulator/devel
7e67f8f 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2305 from sstsimulator/devel
e3d68e7 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2307 from sstsimulator/devel
d46db5f 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2309 from sstsimulator/devel
0a9aaa0 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2312 from sstsimulator/devel
eb16f08 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2316 from sstsimulator/devel
8e32145 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2322 from sstsimulator/devel
54843c2 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2332 from sstsimulator/devel
50b8b83 
Automatically Merged using SST Master Branch Merger
sst-autotester and others added 29 commits July 31, 2025 08:11
@sst-autotester
Merge pull request sstsimulator#2554 from sstsimulator/devel
57b04b8 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2556 from sstsimulator/devel
9f65e92 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2562 from sstsimulator/devel
0427dde 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2570 from sstsimulator/devel
08c5200 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2574 from sstsimulator/devel
da408f1 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2575 from sstsimulator/devel
6028ad3 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2581 from sstsimulator/devel
d082041 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2597 from sstsimulator/devel
55c2322 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2601 from sstsimulator/devel
e853e69 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2612 from sstsimulator/devel
6014ed5 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2614 from sstsimulator/devel
484a234 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2617 from sstsimulator/devel
2e05c4b 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2618 from sstsimulator/devel
3e4b930 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2623 from sstsimulator/devel
036b481 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2626 from sstsimulator/devel
0fb52ff 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2630 from sstsimulator/devel
a5a1bf1 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2631 from sstsimulator/devel
456ae94 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2635 from sstsimulator/devel
e39ffe4 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2640 from sstsimulator/devel
d477da6 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2648 from sstsimulator/devel
12f1b0d 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2655 from sstsimulator/devel
17436f0 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2657 from sstsimulator/devel
a0398ec 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2663 from sstsimulator/devel
e9fa829 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2670 from sstsimulator/devel
139a1d7 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2673 from sstsimulator/devel
53df938 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2675 from sstsimulator/devel
53cc196 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2680 from sstsimulator/devel
8f092a4 
Automatically Merged using SST Master Branch Merger
@sst-autotester
Merge pull request sstsimulator#2685 from sstsimulator/devel
c1014f6 
Automatically Merged using SST Master Branch Merger
@nab880
mercury/nic: key message reassembly by (source, flowId)
695bdc7 
Fixes a high-fan-in abort: same-source flows from different senders were
colliding in the reassembly table.
@nab880 nab880 closed this Jul 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nab880 @sst-autotester