Repository navigation
Fix API error handling and unnecessary reauthorization - #3
Open
econstantin wants to merge 2 commits into
Open
econstantin wants to merge 2 commits into
econstantin wants to merge 2 commits into
Conversation
econstantin
marked this pull request as ready for review
October 23, 2026 04:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
API failures can lose their original error type, trigger repeated authorization attempts, or unnecessarily discard a valid access token.
Repro steps
Using mocked responses:
async_samples()when authorization fails.Expected
Preserve authentication errors, report other failures as library errors, and retain valid tokens after connection or server failures.
Actual
Authorization failures are retried again by the calling method and become general errors. Unexpected response bodies can cause parsing errors. Connection and server failures force reauthorization.
Fix
Testing
Notes
Depends on #2. The current diff includes its test and packaging baseline. Rebase after #2 merges to leave only the API changes, tests, and changelog entries.
HTTP 400 remains an authentication error, matching existing behavior. Retry count and timing for connection and server failures are unchanged.