Repository navigation
Skip sensors without cloud samples - #1
Merged
sstallion merged 1 commit intoOct 19, 2026
Merged
Conversation
Owner
|
Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a sensor is listed by the sensors endpoint but omitted from the samples response,
async_get_data()raisesKeyErrorand the Home Assistant integration cannot complete setup. An empty sample list similarly raisesIndexError.Skip only sensors with a missing or empty sample list and continue processing the remaining readings. A sensor is included automatically on a later update once samples become available. API failures still propagate normally.
Adds regression tests for missing keys, empty lists, healthy readings in a mixed response, resumed samples, and API failures. The same missing-key failure was reproduced against 1.3.2, and this sample-handling change is running successfully in a local Home Assistant override.
Validation:
python -m unittest discover -s tests -v: 3 tests passed on Python 3.13.12 and 3.14.6.python -m build --no-isolation: sdist and wheel built successfully.A patch release after merging would allow Home Assistant to adopt the fix through a normal dependency update.