Fix domain validation regex rejecting consecutive hyphenated subdomain labels

[Copilot]

The denylist/allowlist domain validator incorrectly rejects domains where hyphens appear in two different subdomain labels (e.g. something-one.something-two.sub.root.com), while accepting hyphens within a single label (e.g. something.something-one-two.sub.root.com).

Root cause

The regex in Payload::setList() had a flawed structure that interleaved "hyphenated label" and "non-hyphenated label" matchers:

(hyphenated-label.)? non-hyphenated-label (. (hyphenated-label.)? non-hyphenated-label)*

After consuming something-one. as the leading hyphenated label, the next segment required a hyphen-free label — causing something-two to fail at its hyphen.

Fix

Replace the complex regex with a straightforward per-label pattern that uniformly handles all labels regardless of position:

// Before
'/^(?:(?:(?!\*)[a-zA-Z\d][a-zA-Z\d\-*]{0,61})?[a-zA-Z\d]\.){0,1}(?!\d+)(?!.*\*\*)[a-zA-Z\d*]{1,63}(?:\.(?:(?:(?!\*)[a-zA-Z\d][a-zA-Z\d\-*]{0,61})?[a-zA-Z\d]\.){0,1}(?!\d+)(?!.*\*\*)[a-zA-Z\d*]{1,63})*$/'

// After
'/^(?!.*\*\*)(?:[a-zA-Z\d*](?:[a-zA-Z\d\-*]{0,61}[a-zA-Z\d*])?\.)*[a-zA-Z\d*](?:[a-zA-Z\d\-*]{0,61}[a-zA-Z\d*])?$/'

Each label must start and end with an alphanumeric or * (no leading/trailing hyphens), with hyphens and wildcards permitted in the middle. Double wildcards (**) remain prohibited.

[Copilot]

Pull request overview

This PR updates the allowlist/denylist domain validation in Payload::setList() to stop rejecting domains that contain hyphens in multiple different subdomain labels (e.g., something-one.something-two.sub.root.com) by replacing the previous complex, position-dependent regex with a simpler per-label pattern.

Changes:

• Replaced the domain-validation regex used when adding allowlisted/denylisted domains.
• Normalized validation to apply the same label rules at every dot-separated label position (including hyphen handling) while still disallowing **.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.