build: migrate servicex_app from Flask 2 to Flask 3 - #1501
Open
BenGalewsky wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1501 +/- ##
===========================================
+ Coverage 89.29% 89.30% +0.01%
===========================================
Files 104 104
Lines 3763 3769 +6
Branches 462 464 +2
===========================================
+ Hits 3360 3366 +6
Misses 326 326
Partials 77 77 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
One comment before I look more closely - can we get a test for full coverage of |
Collaborator
|
Less invasive than I expected. Have you checked that |
Bump flask ^2.3.3 -> ^3.1 (resolves to 3.1.3). Werkzeug, Jinja2, and all flask-* extensions were already at Flask-3-compatible versions; flask-restful 0.3.10 verified working against Flask 3.1. Also bump flask-migrate ^3.1.0 -> ^4.1 and pytest-flask ^1.2.0 -> ^1.3.0, and drop the unused .pre-commit-config.yaml (superseded by the repo-root pre-commit config). Assisted-by: ClaudeCode:claude-sonnet-5
BenGalewsky
force-pushed
the
flask3-migration
branch
from
July 9, 2026 19:11
0c562ff to
2ec8326
Compare
- Replace distutils.util.strtobool (removed in Python 3.12) with a local equivalent - Fix Api(app, errors=Flask.errorhandler): the errors kwarg expects a dict of exception-name -> response specs; passing the unbound method was a latent bug that would raise TypeError inside flask-restful error handling Assisted-by: ClaudeCode:claude-sonnet-5
BenGalewsky
force-pushed
the
flask3-migration
branch
from
July 9, 2026 19:14
2ec8326 to
45cabfe
Compare
Contributor
Author
|
@ponyisi - Tests added to bring coverage back up. |
Contributor
Author
Yes, I was girding myself for a major migration |
ponyisi
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump flask ^2.3.3 -> ^3.1 (resolves to 3.1.3). Werkzeug, Jinja2, and all flask-* extensions were already at Flask-3-compatible versions; flask-restful 0.3.10 verified working against Flask 3.1.
Related cleanups:
Assisted-by: ClaudeCode:claude-fable-5