Github: Impose patch version restrictions for minor version increments - #199
Open
KasperThystrup wants to merge 8 commits into
Open
Github: Impose patch version restrictions for minor version increments#199KasperThystrup wants to merge 8 commits into
KasperThystrup wants to merge 8 commits into
Conversation
When making relations between versions numerically (by first removing dot between minor and patch, then by removing the build entirely) every minor releases of 10 leads to ambiguity Example: 2.20.0 SHOULD be greater than 2.2.0 - as in: 2.20.0 > 2.2.0 However 2.20.0 < 2.2.0 numerically becomes 2.200 < 2.20 which is FALSE (it is rather 2.200 == 2.20) This is now circumvented by always setting patch to 1 whenever a new minor is incremented. Now e.g. 2.19.+ minor version increments directly to 2.20.1 Thus we can never get a situation where we get both a version 2.2.0 AND a version 2.20.0
whoops
KasperThystrup
changed the title
github-actions
Bot
added
the
build
Contributor
|
✅ Version label set to build |
Increased delay from 30 seconds to 120 seconds for execution.
KasperThystrup
force-pushed
the
patch_increment_restriction
branch
from
August 5, 2026 11:22
154bcb6 to
449311b
Compare
KasperThystrup
force-pushed
the
patch_increment_restriction
branch
from
August 5, 2026 11:30
dbe8865 to
a503bd0
Compare
KasperThystrup
force-pushed
the
patch_increment_restriction
branch
from
August 5, 2026 11:33
a503bd0 to
698d96a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When making relations between versions numerically (by first removing dot between minor and patch, then by removing the build entirely) every minor releases of 10 leads to ambiguity
Example:
2.20.0 SHOULD be greater than 2.2.0 - as in: 2.20.0 > 2.2.0 However 2.20.0 > 2.2.0 numerically becomes 2.200 > 2.20 which is FALSE -> it is rather 2.200 == 2.20!
This is circumvented by always setting patch to 1 whenever a new minor is increments to a value of 10's, e.g. 2.19.+ minor version increments directly to 2.20.1 instead of 2.20.0.
Thus we can never get a situation where we get both a version 2.2.0 AND a version 2.20.0