Fix stack overflow error for circular dependencies#54
Merged
Conversation
jachiaram
approved these changes
Mar 9, 2026
jachiaram
left a comment
jachiaram
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, I was thinking about a similar solution when I saw the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#52 reported an issue for certain configurations of circular dependencies, where MARIN would run into infinite loops. This PR fixes the issue by using the resolution contexts to keep track of artifacts that are currently being resolved, but not yet finished resolving. This (plus the fact that artifact objects are unique per identifier within their context) allows us to not enter circular resolution loops.
The particular identifier that was causing problems in #52 has been added as a test case for this functionality.