Improve Handling of Cutoff Dates via CLI#49
Merged
Conversation
…amp format from milliseconds to seconds. Update documentation.
jachiaram
approved these changes
Jan 16, 2026
Collaborator
|
Or a better question is for the given skip take configuration, if a library can't be processed should it still be counted as a part of the take? |
Member
Author
|
It took me some time, but i'm finally coming back to this PR 😅 I did a few things to address test failures:
This should fix our test issues. I'm just now seeing a build failure, but its due to some GitHub Internal Server Error when uploading the dependency tree and should be unrelated - i'll do some research and re-trigger the CI run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in #48, we were missing proper documentation for the usage of the time-based artifact filtering via
--since-until. For MARIN 1.0.0, we require both cutoff dates to be specified as UNIX timestamps in milliseconds. While this is what Maven Central provides, it is neither a common format nor very intiutive to users. Therefore, this PR:--since-untilCLI argument. Dates can now be given as either UNIX timestamps in seconds, or as dates in theYYYY-MM-DDformat. For the latter format, the beginning of a time range (i.e., thesincevalue) will be interpreted as the beginning of the specified date (time00:00), while the range end date (i.e., theuntilvalue) will be interpreted as end of day (time 23:59). Specifying--since-until 2025-12-01:2025-12-02will thus include all artifacts release on either December 1st or December 2nd, 2025.--since-untilshowcasing the new formats.ArtifactAnalysisConfigBuilderto include a convenience method that accepts aZonedDateTimeinstead of plainlongvalues for cutoff dates.Note thatDates are converted into timestamps using the GMT timezone - to fine-tune cutoff dates, UNIX time stamps should be used.YYYY-MM-DDdates are converted into timestamps based on the user's default time zoneCloses #48.