Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions estilos.css
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,8 @@
padding-top: 20%;
}

.tamano {
max-width: 100%;
}
/* Se podria dejar como uno */
.tamano,
.tamano2 {
max-width: 100%;
}
Expand Down Expand Up @@ -119,9 +118,11 @@ th {
font-style: italic;
}

/* Falta valor */
td {
font-family: ;
}

th,
td {
padding: 0.25rem;
Expand Down
7 changes: 7 additions & 0 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ <h1><span class="fondoAmarillo">About me</span></h1>
<table class="table">
<thead>
<tr>
<!-- Add either an 'id' or a 'scope' attribute to this <th> tag -->
<th>Day of birth</th>
<th>Hometown</th>
<th>Department</th>
Expand Down Expand Up @@ -244,6 +245,7 @@ <h1><span class="fondoAmarillo">Academic Information</span></h1>
<div class="card">
<div class="card-header" id="headingOne">
<h2 class="mb-0">
<!-- Duplocate id -->
<button id="btnSistemas" class="btn btn-link btn-block text-left collapsed btnAcademico" type="button" data-toggle="collapse" data-target="#collapseOne" aria-expanded="false" aria-controls="collapseOne">
Interests in Compuer Systems Engineering
</button>
Expand Down Expand Up @@ -389,6 +391,7 @@ <h3 class="fuenteRoboto"> <strong>Participants: </strong> </h3>

<div class="col-12 col-md-6">
<div class="embed-responsive embed-responsive-16by9">
<!-- Falta el atributo de titulo para mejorar la accesibilidad -->
<iframe class="embed-responsive-item" src="https://www.youtube.com/embed/qQxNwjg6CN4"></iframe>
</div>
</div>
Expand Down Expand Up @@ -623,3 +626,7 @@ <h5>Correo</h5>
></script>
</body>
</html>

<!-- Review ma.hoyosr: buen trabajo, se comporta bien al cambiar el tamaño de las pantallas.
Se usa mucho el tag h1 aunque no son titulos de prier nivel. Para que queden iguales a un h1 se debe usar css
Tambien mejoraria la estructura del html para que sea mas legible-->
Binary file added validator_ma.hoyosr.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.