Skip to content

Code review hecho #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DaGalR wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Code review hecho #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ac3734
Code review hecho
DaGalR Aug 29, 2020
5c74f88
Evvidencia de validador
DaGalR Aug 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added evidencia-validador.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
37 changes: 27 additions & 10 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ <h1><span class="fondoAmarillo">About me</span></h1>
<p class="lead">In the following table, you wil find some important biographic facts about me:</p>
<div class="table-responsive">
<table class="table">
<caption class="centrado fuenteRoboto">Biographic Data of Sebastián Santos</caption>
<thead>
<tr>
<th>Day of birth</th>
Expand All @@ -144,7 +145,10 @@ <h1><span class="fondoAmarillo">About me</span></h1>
<td class="lead">Bogotá</td>
</tr>
</tbody>
<!-- Segun validator de html, este elemento va como primero hijo de table-->
<!--
<caption class="centrado fuenteRoboto">Biographic Data of Sebastián Santos</caption>
-->
</table>
</div>

Expand Down Expand Up @@ -232,7 +236,10 @@ <h4 class="card-title fuenteRoboto">Cooking</h4>
</section>
</div>
</div>
<!--Sobra este div segun el validador de html-->
<!--
</div>
-->
</section>

<section id="DatosAcademicos">
Expand All @@ -244,7 +251,8 @@ <h1><span class="fondoAmarillo">Academic Information</span></h1>
<div class="card">
<div class="card-header" id="headingOne">
<h2 class="mb-0">
<button id="btnSistemas" class="btn btn-link btn-block text-left collapsed btnAcademico" type="button" data-toggle="collapse" data-target="#collapseOne" aria-expanded="false" aria-controls="collapseOne">
<!--Cambia este id porque se repitió, o hazlo una clase, lo cambie a btnSistemas1-->
<button id="btnSistemas1" class="btn btn-link btn-block text-left collapsed btnAcademico" type="button" data-toggle="collapse" data-target="#collapseOne" aria-expanded="false" aria-controls="collapseOne">
Interests in Compuer Systems Engineering
</button>
</h2>
Expand Down Expand Up @@ -441,9 +449,10 @@ <h3 class="fuenteRoboto"> <strong>Participants: </strong> </h3>
<div class="container h-100">
<div class="row h-100 align-items-center">
<div class="col-12 text-center">
<h1>
<!--Cambié este h1 por h2 porque solo debería haber un h1 en toda la página-->
<h2>
<span class="fondoAmarillo">Interesting Media</span>
</h1>
</h2>
<p class="lead">
<span class="fondoBlanco"
>Some of my favorite images, videos, websites and songs</span
Expand All @@ -456,9 +465,11 @@ <h1>

<section id="Media">
<article id="Images">
<h1 class="centrado">
<!--Cambié este h1 por h2 porque solo debería haber un h1 en toda la página-->

<h2 class="centrado">
<span class="fondoAmarillo">Images</span>
</h1>
</h2>

<div class="container">
<div class="row">
Expand Down Expand Up @@ -547,16 +558,19 @@ <h1 class="centrado">
</article>

<article id="Songs">
<h1 class="centrado">
<!--Cambié este h1 por h2 porque solo debería haber un h1 en toda la página-->

<h2 class="centrado">
<span class="fondoAmarillo">Songs</span>
</h1>
</h2>

<div class="container">
<div class="row centrado">
<div class="col-12 col-md-6 centrado">
<img src="./imagenes/Kanka.jpg" class=" centrado tamano4" alt="Kanka" >
<audio class="centrado" controls>
<source class="centrado" src="./canciones/El Kanka. Canela en Rama.mp3" type="audio/mpeg">
<!--Quité espacios entre el nombre de la cancion por ugerencia del validador-->
<source class="centrado" src="./canciones/ElKanka.CanelaenRama.mp3" type="audio/mpeg">
Your browser does not support the audio element.
</audio>
<p class="lead centrado">Canela En Rama - El Kanka</p>
Expand All @@ -566,7 +580,9 @@ <h1 class="centrado">
<div class="col-12 col-md-6">
<img src="./imagenes/Siento.jfif" class="tamano" alt="Drexler" >
<audio controls>
<source src="./canciones/Seba Jantos x Jorge Drexler x Cardellino - Siento por Ciento (Prod. Cardellino).mp3" type="audio/mpeg">
<!--Quité espacios entre el nombre de la cancion por ugerencia del validador-->

<source src="./canciones/SebaJantosxJorgeDrexlerxCardellino-SientoporCiento(Prod. Cardellino).mp3" type="audio/mpeg">
Your browser does not support the audio element.
</audio>
<p class="lead centrado">Siento Por Ciento - Jorge Drexler, Sebastian Santos, Cardellino</p>
Expand All @@ -587,7 +603,8 @@ <h1 class="centrado">
<p class="d-block mb-3 text-muted">&copy; 2020</p>
</div>
<div class="col-6 col-md">
<p class="fuenteRoboto">Social Media</h5>
<!--cambié la etiqueta de cierre de h5 a p-->
<p class="fuenteRoboto">Social Media</p>

<ul class="list-unstyled text-small">
<li><a class="text-muted" href="https://www.facebook.com/sebassantos20/" target="_blank">Facebook</a></li>
Expand Down