Добавил крафт пожарного атмокостюма#36
Merged
Merged
Conversation
github-project-automation
Bot
moved this to Нужно сделать
in ТАБЛИЦА ПРИОРИТЕТОВ ДЛЯ РАТГОЯ
github-actions
Bot
added
S: Untriaged
S: Needs Review
size/S
🥰 Нет C#
and removed
S: Untriaged
S: Needs Review
size/S
labels
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds Atmos fire suit and helmet lathe recipes, includes them in the Hardsuits recipe pack, and introduces a Tier 2 technology that unlocks the Atmos-related recipes while removing ChangesAtmos hardsuit manufacturing
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches✨ Simplify code
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ast-grep (0.44.1)ast-grep could not parse rule config: /ast-grep-rules/../git/.ast-grep/rules/ss14-xaml-literal-text.yml Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Resources/Prototypes/_Art/Recipes/Lathes/hardsuits.yml`:
- Around line 4-5: Rename the SuitAtmosFire and HelmetAtmosFire prototypes in
Resources/Prototypes/_Art/Recipes/Lathes/hardsuits.yml with the repository
prefix, updating each prototype’s pack and technology references accordingly.
Rename AtmossuitManufacturing in
Resources/Prototypes/_Art/Research/industrial.yml with the same prefix and
update every reference to it.
In `@Resources/Prototypes/Recipes/Lathes/Packs/externalclothes.yml`:
- Around line 14-17: Add YAML-compatible ss14-art markers around the Atmos
recipe-pack additions near the Atmossuit, SuitAtmosFire, and HelmetAtmosFire
entries in
Resources/Prototypes/Recipes/Lathes/Packs/externalclothes.yml#L14-L17. Also
annotate the moved Atmossuit unlock change with an ss14-art marker in
Resources/Prototypes/Research/industrial.yml#L233-L233; no other edits are
required.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 3ad4de72-39ae-41e3-8ee2-f10fb5b281e8
📒 Files selected for processing (4)
Resources/Prototypes/Recipes/Lathes/Packs/externalclothes.ymlResources/Prototypes/Research/industrial.ymlResources/Prototypes/_Art/Recipes/Lathes/hardsuits.ymlResources/Prototypes/_Art/Research/industrial.yml
Comment on lines
+4
to
+5
| id: SuitAtmosFire | ||
| result: ClothingOuterSuitAtmosFire |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Fork prototype IDs must use the repository prefix.
Resources/Prototypes/_Art/Recipes/Lathes/hardsuits.yml#L4-L5: RenameSuitAtmosFireand update its pack and technology references.Resources/Prototypes/_Art/Recipes/Lathes/hardsuits.yml#L14-L15: RenameHelmetAtmosFireand update its pack and technology references.Resources/Prototypes/_Art/Research/industrial.yml#L4-L5: RenameAtmossuitManufacturingand update any references.
📍 Affects 2 files
Resources/Prototypes/_Art/Recipes/Lathes/hardsuits.yml#L4-L5(this comment)Resources/Prototypes/_Art/Research/industrial.yml#L4-L5
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@Resources/Prototypes/_Art/Recipes/Lathes/hardsuits.yml` around lines 4 - 5,
Rename the SuitAtmosFire and HelmetAtmosFire prototypes in
Resources/Prototypes/_Art/Recipes/Lathes/hardsuits.yml with the repository
prefix, updating each prototype’s pack and technology references accordingly.
Rename AtmossuitManufacturing in
Resources/Prototypes/_Art/Research/industrial.yml with the same prefix and
update every reference to it.
Source: Coding guidelines
Comment on lines
+14
to
+17
| # add atmos suit | ||
| - Atmossuit | ||
| - SuitAtmosFire | ||
| - HelmetAtmosFire |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
Annotate all upstream YAML edits.
Resources/Prototypes/Recipes/Lathes/Packs/externalclothes.yml#L14-L17: Add YAML-compatibless14-artmarkers around the Atmos recipe-pack additions.Resources/Prototypes/Research/industrial.yml#L233-L233: Add a YAML-compatibless14-artmarker to the movedAtmossuitunlock change.
📍 Affects 2 files
Resources/Prototypes/Recipes/Lathes/Packs/externalclothes.yml#L14-L17(this comment)Resources/Prototypes/Research/industrial.yml#L233-L233
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@Resources/Prototypes/Recipes/Lathes/Packs/externalclothes.yml` around lines
14 - 17, Add YAML-compatible ss14-art markers around the Atmos recipe-pack
additions near the Atmossuit, SuitAtmosFire, and HelmetAtmosFire entries in
Resources/Prototypes/Recipes/Lathes/Packs/externalclothes.yml#L14-L17. Also
annotate the moved Atmossuit unlock change with an ss14-art marker in
Resources/Prototypes/Research/industrial.yml#L233-L233; no other edits are
required.
Source: Coding guidelines
github-project-automation
Bot
moved this from Нужно сделать
to Сделано
in ТАБЛИЦА ПРИОРИТЕТОВ ДЛЯ РАТГОЯ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Adjustments