This repository was archived by the owner on Oct 8, 2024. It is now read-only.
Capture the end-of-match screenshot before fade-down - #391
Open
PeterJCLaw wants to merge 2 commits into
Open
Conversation
This is derived from lots of manual testing of Webots to find both a point in time and a combination of captures which actually outputs the right frame. While this iteration isn't shippable, I'm committing this as a known working reference.
This reworks the code to be more portable and explains what is going on without fundamentally changing any part of it.
PeterJCLaw
marked this pull request as ready for review
February 24, 2023 19:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes when we capture the end-of-match screenshot to just before the fade-down rather than afterwards, in order to present a more consistent view of the world relative to the captured video.
It appears that the video itself only captures a frame or two into the red fade-down, meaning that there's up to 80ms between the end of the video and when the post-fade-up screenshot is captured. When comparing that screenshot to the end of the video there can therefore be considerable discrepancies, which are rather unexpected.
With this change we present a more consistent view of the world.
Contributes to #386.