Skip to content

add warnings when not nightly or plugins not present #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
louismerlin merged 3 commits into from
Jun 25, 2026
Merged

add warnings when not nightly or plugins not present #182

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9966595
add warnings
vanhauser-thc Jun 21, 2026
dddcec2
Update src/bin/cargo-ziggy/build.rs
vanhauser-thc Jun 22, 2026
d831612
avoid cargo-afl bug when building plugins
vanhauser-thc Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/bin/cargo-ziggy/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,14 @@ fn is_using_nightly_toolchain() -> bool {
String::from_utf8_lossy(&out.stdout).contains("nightly")
}

fn afl_plugins_installed(common: &Common) -> bool {
common
.cargo()
.args(["afl", "--version"])
.output()
.is_ok_and(|out| String::from_utf8_lossy(&out.stdout).contains("with plugins"))
}

impl Build {
/// Build the fuzzers
pub fn build(&self, common: &Common) -> Result<(), anyhow::Error> {
Expand All @@ -26,8 +34,22 @@ impl Build {
bail!("ASAN requires nightly toolchain");
}

if !is_nightly {
eprintln!(
" {} the Rust toolchain is not nightly; AFL++ CMPLOG and ASAN instrumentation are unavailable",
style("Warning:").yellow().bold()
);
}

let cx = Context::new(common, self.target.clone())?;

if is_nightly && !self.no_afl && !afl_plugins_installed(common) {
eprintln!(
" {} the AFL++ LLVM plugins are not available; build them with `cargo afl config --update --plugins --verbose`",
style("Warning:").yellow().bold()
);
}

if !self.no_afl {
eprintln!(" {} afl", style("Building").red().bold());
let target_dir = format!("--target-dir={}", cx.target_dir.join("afl"));
Expand Down