Phase 2–3: Usable without Carthage (verify + SPM Xcode + XCFramework)#40
Merged
Conversation
…#38) - Xcode project links RIBs-iOS 1.0 and RxSwift 6 via SPM (no Carthage checkout) - Regenerate Products/RIBsTreeViewerClient.xcframework (1.0.8, @available iOS 15) - Add scripts/verify.sh and CI ios job runs full usability checks - README: Quick start, SPM-first integration, deprecate Carthage - Makefile: drop Carthage setup targets; add verify target
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the usability gap after #39. Part of #38.
Verification (ran locally on clean clone, no Carthage)
npm ciyarn buildChanges
Phase 2 — Xcode / CI
RIBsTreeViewerClient.xcodeprojuses Swift Package dependencies (RIBs-iOS, RxSwift) instead of Carthage XCFrameworksiosjob runs./scripts/verify.sh(removed Carthagesetup-ci+ duplicatespmjob)scripts/build-xcode-project.sh,scripts/verify.shPhase 3 — XCFramework
Products/RIBsTreeViewerClient.xcframework(1.0.8,@available(iOS 15.0))make generate_xcframeworksresolves SPM packages (no Carthage prerequisite)Docs
verifytarget; removed CarthagesetuptargetsUsable workflow
cd WebSocketServer && npm startcd Browser && yarn build && open ./public/index.htmlRIBsTreeViewerImpl→ws://127.0.0.1:8080Phase 4 (follow-up, not in this PR)
Cartfile, Carthage patch scripts,DeploymentTarget.xcconfig