Dense grouped gemm tests - #1
Merged
sraman-rgb merged 1 commit intoApr 17, 2026
Merged
Conversation
The dense_grouped_gemm feature introduces a feature-detection branch (via inspect.signature) in transformer_engine_layer_spec that was uncovered — codecov flagged it on the fork's PR. Adds four unit tests: attribute default, attribute settable, and both branches of the signature check (forwarded when supported, omitted otherwise) using patched fakes whose signatures include or exclude the parameter. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Michal Futrega <mfutrega@nvidia.com>
michal2409
force-pushed
the
dense_grouped_gemm-tests
branch
from
April 17, 2026 12:54
0f3a037 to
2feb7e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Changelog
GitHub Actions CI
See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information