Fix: Handle empty Assembly.Location in single-file published apps - #221
Merged
albertospelta merged 2 commits intoApr 16, 2026
Merged
Conversation
Standardize on AssemblyInformationalVersionAttribute instead of FileVersionInfo, which requires Assembly.Location. This provides a single consistent approach across all deployment types including single-file published apps. Also reverts accidental tabs-to-spaces indentation change in Model.cs.
albertospelta
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two places in the codebase call
FileVersionInfo.GetVersionInfo(assembly.Location):Util.GetExtractorInfo()inDax.Model.ExtractorModel()constructor inDax.MetadataBoth throw an
ArgumentExceptionwhen the consuming application is published as a .NET single-file executable. In single-file mode, managed assemblies are loaded from memory andAssembly.Locationreturns an empty string, causingPath.GetFullPath("")to fail.This makes it impossible to use
TomExtractor.GetDaxModel()from a single-file app without settingIncludeAllContentForSelfExtract=true, which forces all bundled content to be extracted to a temp directory on disk. This is defeating much of the benefit of single-file publishing.Fix
Use
AssemblyInformationalVersionAttributefor version retrieval. Standardize onAssemblyInformationalVersionAttributeinstead ofFileVersionInfo, which requiresAssembly.Location. This provides a single consistent approach across all deployment types including single-file published apps.Files changed:
src/Dax.Model.Extractor/Util.cs—GetExtractorInfo()src/Dax.Metadata/Model.cs—Model()constructorImpact
No behavior change for existing consumers.