CC-39779: Add static validation skill for Spryker changes - #26
Conversation
| ## Features | ||
|
|
||
| - **Flexible base branch.** `--base <ref>` for any branch (`master`, `main`, `master-demo`, | ||
| `develop`, a release branch, …). Auto-detects when omitted (`master-demo` → `master` → `main` → |
There was a problem hiding this comment.
I don't think we need to mention master-demo here - it is only specific for our development cycle.
There was a problem hiding this comment.
correct, I will remove it
There was a problem hiding this comment.
Done — removed master-demo from the README (base-branch examples + auto-detect chain) and from SKILL.md and the script's auto-detect. Auto-detect is now master → main → remote default.
Automatic reply by AI.
|
|
||
| ```bash | ||
| # Preview what would be checked (no tools run): | ||
| bash ${CLAUDE_PLUGIN_ROOT}/skills/static-validation/scripts/static-check-diff.sh --dry-run |
There was a problem hiding this comment.
Did you test it when skills are installed via the ai-dev SDK setup command? Does it have any issues with the script path location?
There was a problem hiding this comment.
${CLAUDE_PLUGIN_ROOT} is clear for both plugin and project skill providing
There was a problem hiding this comment.
Nice, if it is confirmed that it works with both installations, feel free to resolve the thread.
There was a problem hiding this comment.
Update: dropped ${CLAUDE_PLUGIN_ROOT} entirely to keep the skill tool-agnostic. All command examples now use the relative bash scripts/static-check-diff.sh (run from the skill directory), so there is no dependency on an install-path variable either way.
Automatic reply by AI.
| It replaces the fixed `.claude/bash-local/validation.sh` / `validation-master.sh` scripts with a | ||
| single flexible engine: |
There was a problem hiding this comment.
Were there any scripts already installed?
There was a problem hiding this comment.
you are correct
I will remove it
There was a problem hiding this comment.
Done — removed the reference to the project-local .claude/bash-local/validation.sh / validation-master.sh scripts; the intro now says it replaces "fixed, single-base validation scripts".
Automatic reply by AI.
…nd improve base branch detection
2 participants
https://spryker.atlassian.net/browse/CC-39779
PR Description
Add a meaningful description here that will let us know what you want to fix with this PR or what functionality you want to add.
Steps before you submit a PR
contribution-license-agreement.txtfile with the following content:I hereby agree to Spryker's Contribution License Agreement in https://github.com/spryker/incremental-installer/blob/HASH_OF_COMMIT_YOU_ARE_BASING_YOUR_BRANCH_FROM_MASTER_BRANCH/CONTRIBUTING.md.This is a mandatory step to make sure you are aware of the license agreement and agree to it.
HASH_OF_COMMIT_YOU_ARE_BASING_YOUR_BRANCH_FROM_MASTER_BRANCHis a hash of the commit you are basing your branch from the master branch. You can take it from commits list of master branch before you submit a PR.Checklist