Refactor PetClinic low-risk cleanup batch - #282
Open
formatunitedandreas-code wants to merge 66 commits into
Open
Refactor PetClinic low-risk cleanup batch#282formatunitedandreas-code wants to merge 66 commits into
formatunitedandreas-code wants to merge 66 commits into
Conversation
PR #1 branch threshold-governed-refactor-demo local validation: Maven test BUILD SUCCESS CI: all visible checks passed non-claims: no upstream interaction, no release, no deploy, no public readiness/correctness/security/compliance claim
Local validation passed: git diff --check and mvnw test (BUILD SUCCESS). Merge of follow-up low-risk cleanup commits on threshold-governed-refactor-demo.
Split main CI into an unconditional Maven verify step and a Sonar analysis step gated on SONAR_TOKEN. This keeps the owned fork main workflow green when SonarCloud secrets are not configured.
PR #5\nbranch threshold-governed-refactor-demo-3\nlocal validation: Maven test BUILD SUCCESS\nCI: all visible checks passed\nnon-claims: no upstream interaction, no release, no deploy, no public readiness/correctness/security/compliance claim
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor PetClinic low-risk cleanup batch
Summary
This PR applies a sequence of small readability refactorings across PetClinic
controllers, validators, service/model helpers, and related low-risk paths.
The changes focus on:
validation, repository, or persistence semantics
Validation
Local validation on Windows with Java 17:
Result:
Current CI State
GitHub Actions for this fork PR currently require maintainer approval before
jobs run:
action_requiredaction_requiredScope Notes
message/code, repository query, or persistence behavior change is intended.
Non-Claims
This PR does not claim production readiness, security certification, compliance
certification, or upstream acceptance.