Repository navigation
MustacheTemplateRenderer doesn't close the reader - #1822
Merged
Merged
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
See spring-iogh-1822 Signed-off-by: sijun-yang <yangsijun5528@gmail.com>
mhalbritter
changed the title
mhalbritter
added
type: bug
and removed
status: waiting-for-triage
mhalbritter
force-pushed
the
mustache-reader-leak
branch
from
August 28, 2026 08:18
588915e to
460bebf
Compare
Contributor
|
Thanks @YangSiJun528 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TemplateLoader contract states that the returned Reader will be closed. MustacheTemplateRenderer currently calls getTemplate and compile separately, leaving it open.
Use Compiler.loadTemplate(String), which performs both operations and closes the reader in a finally block.