Skip to content

feat: loop simulation with tail overlap#21

Merged
seoJing merged 2 commits into
mainfrom
feat/sim-loop-tail-overlap
Jun 11, 2026
Merged

feat: loop simulation with tail overlap#21
seoJing merged 2 commits into
mainfrom
feat/sim-loop-tail-overlap

Conversation

@seoJing

@seoJing seoJing commented Jun 7, 2026

Copy link
Copy Markdown
Member

Summary

  • loop simulation playback by loop_period_ticks instead of waiting through an empty post-run gap
  • preload projected tail chunks up to max_projected_tick
  • render previous-cycle tail and current-cycle start with cycle-scoped ids so returning personas do not all disappear at the same time

Verification

  • git diff --check origin/main...HEAD
  • security scan on added lines: no hits
  • pnpm lint → 0 errors, 6 existing warnings
  • pnpm build
  • ocr review --audience agent --from origin/main --to HEAD → 0 comments

@vercel

vercel Bot commented Jun 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontend Ready Ready Preview, Comment Jun 7, 2026 10:44am

@coderabbitai

coderabbitai Bot commented Jun 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seoJing, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 59 minutes and 59 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e1edbe9b-c457-4842-9a61-4e83381971c8

📥 Commits

Reviewing files that changed from the base of the PR and between 56a9f03 and 6e5e67a.

📒 Files selected for processing (6)
  • src/entities/spot/sim-stream-types.ts
  • src/features/map/client/MapClient.tsx
  • src/features/map/model/types.ts
  • src/features/simulation/model/sim-clock.ts
  • src/features/simulation/model/sim-domain-adapter.ts
  • src/features/simulation/model/use-sim-run.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/sim-loop-tail-overlap

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@seoJing

seoJing commented Jun 7, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Jun 7, 2026

Copy link
Copy Markdown
✅ Action performed

Full review finished.

@seoJing seoJing merged commit ad1f507 into main Jun 11, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant