✨ feat(workers): add static-asset deployment baseline#12
Conversation
zrr1999
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f01b714210
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| run: pnpm check | ||
|
|
||
| - name: Generate worker types | ||
| run: pnpm types |
There was a problem hiding this comment.
Replace this step with a non-mutating check (wrangler types --check) because pnpm types rewrites worker-configuration.d.ts and lets pull requests pass even when committed generated types are stale. In that scenario, drift is only caught later in .github/workflows/deploy-workers.yml at the Check worker types step, so a bad merge can block deployments on main instead of failing in PR validation.
Useful? React with 👍 / 👎.
Wire the three Astro apps to Cloudflare Workers + Static Assets, add deployment workflows and type generation, and roll out the requested runtime and OG font strategy. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Introduced a new DESIGN.md file detailing the Spore design system, including brand guidelines, color palettes, typography, and component specifications. - Updated .gitignore to include worker-configuration.d.ts files to prevent tracking of generated types. - Adjusted package.json and CI configurations to streamline type generation and checks.
- Changed the description in DESIGN.md to use quotes for better formatting and clarity.
fbaff36 to
2f49053
Compare
1 participant
Summary
Validation
Notes