♻️ refactor: align basic-cli with effect terminology#12
Closed
zrr1999 wants to merge 15 commits into
Closed
Conversation
Platform modules (.sp): Stdout, Stdin, File, Dir, Env, Cmd Rust host: 15 foreign fn implementations, 7 tests Examples: hello, file-copy, env-reader CI: fmt + clippy + test Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…n) (#1) - StdOut, StdErr, StdIn → Console (unified console I/O intent) - EnvVar → Env (environment access intent) - Exec → Spawn (process spawning intent) - FileRead, FileWrite unchanged (already intent-oriented) - Updated platform modules, examples, and README Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* feat: add platform spec tests, fix syntax issues, update CI - Add tests/platform_check.sp with 34 specs across 13 pure helpers - Fix clause ordering in File.sp, Dir.sp, Cmd.sp (! before uses) - Fix main.sp import syntax, examples remove invalid top-level uses - Add spore-check job to CI workflow Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * ci: remove spore test step until spore-test lands on main The spore test subcommand is in spore-lang/spore PR #55 and not yet on main. Remove the step to unblock CI; re-add once #55 merges. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * 👷 ci: standardize zendev checks and workflow layout\n\nAdopt a zendev-style prek baseline, split CI into static/tests/PR\nchecks, and keep the existing host plus Spore integration coverage\nunder the normalized workflow structure.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * 👷 ci: repin PR title validation to portable zendev action\n\nUse the follow-up zendev action fix that validates titles from source\nwithout depending on hatch-vcs metadata in a checked-out .git-less\naction bundle.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * 👷 ci: repin PR title validation to final zendev fix\n\nMove from the intermediate portable-action commit to the final source-load\nfix in zendev, which removes the remaining import-chain dependency in\nremote action executions.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * 👷 ci: switch PR title checks to zendev-actions\n\nUse the standalone zrr1999/zendev-actions wrapper instead of consuming\nthe action embedded in zendev directly. The wrapper now shells out via\nuvx --from git+ to zendev-validate-title.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * 🔧 expand basic-cli CI coverage Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * 👷 ci: tighten basic-cli example coverage Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * 📝 docs: tighten examples wording Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * 🧪 test: remove misleading spec smoke Drop the fake tests/platform_check.sp fixture, stop advertising Spore-side regression coverage that the repo does not actually have, and only run spore test in CI when real tests exist. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * 🐛 fix: restore doc comments, fix error set syntax (D11), remove Ruby workaround - Restore /// doc comments on all platform/*.sp files (spore formatter now preserves them) - Fix error set syntax: ! [Error] → ! Error (D11: pipes, no brackets) - Fix clause order: ! before uses (parser requirement) - Fix hello.sp: remove invalid module-level uses, Unit → () - Remove Ruby error-set normalization workaround from CI (no longer needed) - Fix README: update code example and error set documentation Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chore: align examples, docs, and CI validation Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chore: repin spore CI to current main * Trigger PR workflows for stacked branches * 👷 ci: validate PR description headings * �� ci: unify PR body check naming --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* ✨ feat(layout): migrate basic-cli package layout Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * 👷 ci: align package-layout spore checks Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * 👷 ci: align host format validation --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* 🔧 fix: restore package-backed basic-cli canon Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * 🔧 fix: realign package-backed basic-cli docs and CI Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* 👷 ci: add actionlint to ci-static-checks Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * 👷 ci: pin actionlint to an existing tag Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…#11) Aligns `process_run_status` and `exit` return/parameter types from `Int` to `I32`, following the spore int-type-split change (Ty::Int → sized variants). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
basic-cliconsistently uses required effects / handled effects terminologyValidation
cargo build --manifest-path host/Cargo.toml../spore/target/release/spore format --check examples/hello-app/src/main.sp src/platform_contract.sp src/host.sp../spore/target/release/spore check src/basic_cli/cmd.sp src/basic_cli/file.sp src/basic_cli/stdout.sp src/platform_contract.sp src/host.sp(cd examples/hello-app && ../../../spore/target/release/spore check src/main.sp && ../../../spore/target/release/spore build src/main.sp && ../../../spore/target/release/spore run src/main.sp)Notes
spore