test(ci): real miniwdl engine-composition test against Substrate - #3
Merged
Merged
Conversation
Runs REAL 'miniwdl run' through the spawn backend against the Substrate AWS emulator (substrate v0.75.0) — no real AWS, no cost, hermetic. Full seam: miniwdl → SpawnContainer → real 'spawn task run' + real 'aws s3' staging vs Substrate → completion record → exit code → task success/failure. Substrate serves the completion as a seedable clock-aware outcome (substrate#360): unseeded ⇒ nominal exit 0 (happy path, no seed); POST /v1/spawn/task-completion with exit 7 drives the failure path → miniwdl CommandFailed exit_status 7. Uses a no-output WDL (noout.wdl) since Substrate doesn't execute the workload — output collection needs real execution (covered by the real-AWS run, not here). Validated locally end-to-end before commit (both paths green, exit 0). Template for the same guard on the other adapters (airflow-spawn, snakemake-executor-plugin-spawn).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a real-engine CI regression guard: runs actual `miniwdl run` through the spawn backend against the Substrate AWS emulator — no real AWS, no cost, hermetic and deterministic.
What it proves
Full composition seam, on every push:
miniwdl run→SpawnContainerbackend → realspawn task run(real RunInstances + realaws s3staging, all vs. Substrate) → completion record → exit code → miniwdl task success/failure.exit 0/completed⇒miniwdl runsucceeds; asserts the backend actually dispatchedspawn task run.wdl-call-step-1to exit 7 via substrate#360'sPOST /v1/spawn/task-completion⇒ miniwdl reportsCommandFailed exit_status 7.Why Substrate + why a no-output WDL
Substrate (v0.75.0) serves the task-completion record as a seedable, clock-aware outcome (substrate#360) — real spawn + real S3 staging, only the completion outcome seeded. It does not execute the workload, so the test uses a deliberately no-
File-output workflow (tests/composition/noout.wdl); output collection needs real execution and is covered by the real-AWS run, not here.Validation
Ran the whole chain locally end-to-end before committing (Substrate v0.75.0 + spawn v0.95.0 + miniwdl v1.15.0): both paths green, script exits 0. The CI job installs Substrate (
go install), the spawn release binary (curl), and miniwdl+adapter (pip).Template for the same guard on airflow-spawn and snakemake-executor-plugin-spawn (spore-host#397).