Skip to content

Release v4.5.0 - #36

Open
sporaktu wants to merge 1 commit into
masterfrom
release/v4.5.0
Open

Release v4.5.0#36
sporaktu wants to merge 1 commit into
masterfrom
release/v4.5.0

Conversation

@sporaktu

@sporaktu sporaktu commented Aug 1, 2026

Copy link
Copy Markdown
Owner

Release v4.5.0

Bumps the version to 4.5.0 (minor). Merge this to bring the version bump back into master after the release build runs.

What's in this release (since v4.4.0)

Everything from #35 — three bug fixes reported against the Android build:

  • Mute button was unreachable in the fullscreen viewer. The mute toggle was pinned at safeAreaTop + 10 / safeAreaRight + 10, the exact rect PostOverlay's close button occupies. MediaViewer renders that overlay in a container with zIndex: 1, above the video cell, so the close button covered the mute button and swallowed its taps. Both video controls now share one top-left row, clear of the close button at any inset.
  • Chipmunk voices above 1x playback. expo-video documents preservesPitch as defaulting to true, but its Android VideoPlayer initializes the field to false, so PlaybackParameters got pitch = speed. It is now pinned on at the single shared-player creation point and re-applied whenever the rate button changes the rate.
  • Multireddits. Browsing someone else's multireddit rendered as a blank feed — your own multis work only because getMyMultis() primes the subreddit-name cache at startup, so the cold-cache path was the one failing, and every way it could fail collapsed into "no posts". Three separate causes: getMergedMultiFeedURL swallowed errors into null; Reddit's error envelopes ({ error: 403 }) parsed as zero subreddits and got cached for the session; and jsonify() appended .json onto a path that still had its trailing slash, so the fallback requested /user/bob/m/tech/.json. Failures now surface through the existing accessFailure UI instead of a blank page. Separately, addToMulti/removeFromMulti were building a doubled slash before /r/<sub>, silently breaking "Add to Multireddit" and "Delete From Multireddit".

⚠️ Manual step required — the tag still has to be pushed

The CircleCI release workflow (EAS iOS build → TestFlight, plus the Android build) triggers only on a v* tag.circleci/config.yml opts tags in and ignores all branches. This session's git proxy allows branch pushes but returns HTTP 403 on tag pushes, so v4.5.0 could not be created from here. Everything else is done: the bump commit is on this branch and the version reads 4.5.0.

Option A — GitHub UI: Releases → Draft a new release → tag v4.5.0, target release/v4.5.0 → Publish. Publishing creates the tag and starts the build.

Option B — local git:

git fetch origin
git tag -a v4.5.0 -m "Release v4.5.0" origin/release/v4.5.0
git push origin v4.5.0

Either way the tag must point at 163d128 (chore: bump version to 4.5.0) on this branch, so the built app reports 4.5.0. Merge this PR once the build is underway.

Note on the version number

master was reporting 4.4.0 only after #34 was merged as part of cutting this release — the v4.4.0 tag had shipped but its bump had never come back to master. That is now in sync, so 4.5.0 follows cleanly from it.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants