Release v4.5.0 - #36
Open
sporaktu wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v4.5.0
Bumps the version to 4.5.0 (minor). Merge this to bring the version bump back into
masterafter the release build runs.What's in this release (since v4.4.0)
Everything from #35 — three bug fixes reported against the Android build:
safeAreaTop + 10/safeAreaRight + 10, the exact rectPostOverlay's close button occupies.MediaViewerrenders that overlay in a container withzIndex: 1, above the video cell, so the close button covered the mute button and swallowed its taps. Both video controls now share one top-left row, clear of the close button at any inset.expo-videodocumentspreservesPitchas defaulting totrue, but its AndroidVideoPlayerinitializes the field tofalse, soPlaybackParametersgotpitch = speed. It is now pinned on at the single shared-player creation point and re-applied whenever the rate button changes the rate.getMyMultis()primes the subreddit-name cache at startup, so the cold-cache path was the one failing, and every way it could fail collapsed into "no posts". Three separate causes:getMergedMultiFeedURLswallowed errors intonull; Reddit's error envelopes ({ error: 403 }) parsed as zero subreddits and got cached for the session; andjsonify()appended.jsononto a path that still had its trailing slash, so the fallback requested/user/bob/m/tech/.json. Failures now surface through the existingaccessFailureUI instead of a blank page. Separately,addToMulti/removeFromMultiwere building a doubled slash before/r/<sub>, silently breaking "Add to Multireddit" and "Delete From Multireddit".The CircleCI
releaseworkflow (EAS iOS build → TestFlight, plus the Android build) triggers only on av*tag —.circleci/config.ymlopts tags in and ignores all branches. This session's git proxy allows branch pushes but returns HTTP 403 on tag pushes, sov4.5.0could not be created from here. Everything else is done: the bump commit is on this branch and the version reads 4.5.0.Option A — GitHub UI: Releases → Draft a new release → tag
v4.5.0, targetrelease/v4.5.0→ Publish. Publishing creates the tag and starts the build.Option B — local git:
Either way the tag must point at
163d128(chore: bump version to 4.5.0) on this branch, so the built app reports 4.5.0. Merge this PR once the build is underway.Note on the version number
masterwas reporting 4.4.0 only after #34 was merged as part of cutting this release — thev4.4.0tag had shipped but its bump had never come back tomaster. That is now in sync, so 4.5.0 follows cleanly from it.Generated by Claude Code