Skip to content

Fix test assertion for paginated results#331

Open
michael-burt wants to merge 3 commits into
splunk:mainfrom
michael-burt:test-assertion-fix
Open

Fix test assertion for paginated results#331
michael-burt wants to merge 3 commits into
splunk:mainfrom
michael-burt:test-assertion-fix

Conversation

@michael-burt

@michael-burt michael-burt commented Apr 14, 2025

Copy link
Copy Markdown
Collaborator

Fixes #277

@harsimranmaan

harsimranmaan commented Jul 9, 2025

Copy link
Copy Markdown
Contributor

IIRC, this'll need an api version upgrade too.

michael-burt and others added 2 commits June 11, 2026 19:46
@michael-burt
Fix test assertion for paginated results
dd5562b
@michael-burt @claude
Fix pagination test: use string continue token and restore fatal asse…
430a2cc 
…rtion

The fake dynamic client's GetContinue() reads the continue field via
getNestedString, which returns "" for non-string values. Storing the
continue value as int64 caused FollowContinue to stop after the first
page. Switch to a non-empty string token for pages with remaining items.

Also remove the t.Logf workaround left from the upstream k8s bug
(kubernetes/kubernetes#107277, fixed in k8s v1.26); the assertion is
now fully enforced.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

1 out of 2 committers have signed the CLA.
✅ @michael-burt
❌ @michael Burt
Michael Burt seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

1 similar comment
@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

1 out of 2 committers have signed the CLA.
✅ @michael-burt
❌ @michael Burt
Michael Burt seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@michael-burt @claude
Clean up pagination test helpers
6d2a661 
- Fix off-by-one in uns slice creation (< instead of <=)
- Use SetContinue() in newUnstructuredList instead of storing "" explicitly
- Simplify continue token condition to callIndex+1 < totalItemsInList

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@michael-burt

michael-burt commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove commented out test assertion

2 participants

@michael-burt @harsimranmaan