Sanchaga/bottestzscaler37 - #48
Conversation
|
Merging this PR will release 3.1.0 (2026-08-07)Connector release changes
|
| next_phantom_ip: ${{ vars.PHANTOM_INSTANCE_NEXT_OL8_VERSION_IP }} | ||
| previous_phantom_ip: ${{ vars.PHANTOM_INSTANCE_PREVIOUS_VERSION_IP }} | ||
| phantom_username: ${{ vars.PHANTOM_USERNAME }} | ||
| phantom_password: password |
There was a problem hiding this comment.
Issue: pre-commit pipeline job failed
Evidence: Primary failure: detect-secrets reported Secret Keyword at .github/workflows/agentic-pr-review.yml:296 Pipeline: pre-commit failed job Code reference: GitHub Actions job pre-commit Changed line (.github/workflows/agentic-pr-review.yml:296): phantom_password: password
Impact: This review job runs after the connector pipeline, so a failed required pipeline job blocks a clean merge signal even if the code review also finds issues.
Recommendation: Fix the primary detect-secrets failure first: remove the secret-like value at .github/workflows/agentic-pr-review.yml:296, or add an inline allowlist/baseline update only after confirming it is a false positive. Rerun pre-commit after committing those changes.
|
Issue: Evidence: Primary failure: Impact: This review job runs after the connector pipeline, so a failed required pipeline job blocks a clean merge signal even if the code review also finds issues. Recommendation: Fix the workflow/action input that builds the compile command so |
| self._headers = {"cookie": self._response.headers["Set-Cookie"].split(";")[0].strip()} | ||
| return phantom.APP_SUCCESS | ||
|
|
||
| def _generate_oauth_access_token(self, action_result: ActionResult) -> str | None: |
There was a problem hiding this comment.
Issue: Code emits action_result.data but app JSON declares no data output
Evidence: Changed line (zscaler_connector.py:347): def _generate_oauth_access_token(self, action_result: ActionResult) -> str | None: Reason: _handle_test_connectivity() calls add_data(), but 'zscaler.json' action 'test connectivity' has no action_result.data.* output paths.
Impact: SOAR playbooks, docs, and result views rely on app JSON output paths matching emitted action data.
Recommendation: Declare the emitted action_result.data.* fields in app JSON or stop emitting undeclared data.
Features
List any features you're adding to this app (e.g. new actions, parameters, auth methods, etc.)
Bug Fixes
Describe any bugs you've fixed in this app, and how they were fixed
Manual Documentation
Have you made any changes that should be documented in manual_readme_content.md?
The following changes require documentation in
manual_readme_content.md:Other information
Please refer to our Contribution Guide for any questions on submitting a pull request.
Thanks for contributing!