Skip to content

Sanchaga/bottestzscaler37 - #48

Open
sanchaga-splunk wants to merge 5 commits into
mainfrom
sanchaga/bottestzscaler37
Open

Sanchaga/bottestzscaler37#48
sanchaga-splunk wants to merge 5 commits into
mainfrom
sanchaga/bottestzscaler37

Conversation

@sanchaga-splunk

Copy link
Copy Markdown

Features

List any features you're adding to this app (e.g. new actions, parameters, auth methods, etc.)

  • BOT TEST

Bug Fixes

Describe any bugs you've fixed in this app, and how they were fixed

Manual Documentation

Have you made any changes that should be documented in manual_readme_content.md?

The following changes require documentation in manual_readme_content.md:

  • New, updated, or removed REST handlers
  • New, updated, or removed authentication methods, especially complex methods like OAuth
  • Compatibility considerations with respect to deployment types (e.g. actions that cannot be run on cloud or an automation broker)
  • I have verified that manual documentation has been updated where appropriate

Other information


Please refer to our Contribution Guide for any questions on submitting a pull request.

Thanks for contributing!

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Merging this PR will release 3.1.0 with the following release notes:

3.1.0 (2026-08-07)

Connector release changes

  • Added OAuth support

next_phantom_ip: ${{ vars.PHANTOM_INSTANCE_NEXT_OL8_VERSION_IP }}
previous_phantom_ip: ${{ vars.PHANTOM_INSTANCE_PREVIOUS_VERSION_IP }}
phantom_username: ${{ vars.PHANTOM_USERNAME }}
phantom_password: password

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: pre-commit pipeline job failed

Evidence: Primary failure: detect-secrets reported Secret Keyword at .github/workflows/agentic-pr-review.yml:296 Pipeline: pre-commit failed job Code reference: GitHub Actions job pre-commit Changed line (.github/workflows/agentic-pr-review.yml:296): phantom_password: password

Impact: This review job runs after the connector pipeline, so a failed required pipeline job blocks a clean merge signal even if the code review also finds issues.

Recommendation: Fix the primary detect-secrets failure first: remove the secret-like value at .github/workflows/agentic-pr-review.yml:296, or add an inline allowlist/baseline update only after confirming it is a false positive. Rerun pre-commit after committing those changes.

@soar-connectors-pr-review-bot

Copy link
Copy Markdown

Issue: compile pipeline job failed

Evidence: Primary failure: compile_app_in_instance.py was invoked with --app-repo-branch but no value Pipeline: compile failed job Code reference: GitHub Actions job compile

Impact: This review job runs after the connector pipeline, so a failed required pipeline job blocks a clean merge signal even if the code review also finds issues.

Recommendation: Fix the workflow/action input that builds the compile command so --app-repo-branch receives a non-empty branch/ref value, or omit that flag when the value is empty. For PR workflows, use the pull request head ref/SHA instead of an unset branch variable, then rerun compile.

Comment thread zscaler_connector.py
self._headers = {"cookie": self._response.headers["Set-Cookie"].split(";")[0].strip()}
return phantom.APP_SUCCESS

def _generate_oauth_access_token(self, action_result: ActionResult) -> str | None:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: Code emits action_result.data but app JSON declares no data output

Evidence: Changed line (zscaler_connector.py:347): def _generate_oauth_access_token(self, action_result: ActionResult) -> str | None: Reason: _handle_test_connectivity() calls add_data(), but 'zscaler.json' action 'test connectivity' has no action_result.data.* output paths.

Impact: SOAR playbooks, docs, and result views rely on app JSON output paths matching emitted action data.

Recommendation: Declare the emitted action_result.data.* fields in app JSON or stop emitting undeclared data.

@soar-connectors-pr-review-bot soar-connectors-pr-review-bot Bot added the ai-reviewed Reviewed by the agentic PR review bot label Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-reviewed Reviewed by the agentic PR review bot splunk-supported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant