Skip to content

fix: preserve Zscaler pagination results - #44

Merged
sodle-splunk merged 4 commits into
mainfrom
jacobd-codex-espm-5228-zscaler-july
Jul 21, 2026
Merged

fix: preserve Zscaler pagination results#44
sodle-splunk merged 4 commits into
mainfrom
jacobd-codex-espm-5228-zscaler-july

Conversation

@phantom-jacob

@phantom-jacob phantom-jacob commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • count records returned by Zscaler in the admin-user, user, group, and batched-group pagination loops
  • normalize HTTP and HTTPS URL schemes before Zscaler URL list actions submit or match entries
  • bound get denylist regular-expression evaluation in a subprocess so a costly query cannot pin the action worker
  • refresh connector validation hooks

Tracking

  • PAPP-38310 (ESPM-5228)
  • PSAAS-32647
  • PSAAS-32634 (VULN-95357, FS-4332)
  • PSAAS-33137 (VULN-96707, FS-5292)

PSAAS-32519 is intentionally not covered by this PR pending an operator decision on ZIA allowlist and denylist semantics. No allowlist entries are changed.

Validation

  • /opt/homebrew/bin/python3.13 -m py_compile zscaler_connector.py
  • helper smoke tests for mixed-case schemes, invalid regexes, and a timeout-triggering regex
  • git diff --check
  • full pre-commit run --all-files
  • hosted pre-commit and compile checks pending after the update

Written by Codex.

Authored by Codex for ESPM-5228.
Counts received records against each directory pagination limit.

Remediates PSAAS-32647.

Authored by Codex for ESPM-5228.
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown

Merging this PR will release 3.0.3 with the following release notes:

3.0.3 (2026-07-21)

Connector release changes

  • Refresh development validation tooling. [PSAAS-32647]

  • Continue Zscaler directory pagination when a response returns a short page. [PSAAS-32647]

  • Normalize URL schemes before applying Zscaler URL list actions. [PSAAS-32634]

  • Bound denylist regular-expression filtering to keep Zscaler actions responsive. [PSAAS-33137]

@phantom-jacob
phantom-jacob marked this pull request as ready for review July 21, 2026 10:20
Handles case-insensitive HTTP and HTTPS URL schemes before Zscaler URL actions submit or match list entries.

Remediates PSAAS-32634 (VULN-95357, FS-4332).

Authored by Codex for ESPM-5228.
@phantom-jacob
phantom-jacob marked this pull request as draft July 21, 2026 11:55
Evaluates get denylist regular-expression queries in a separate process with a five-second timeout so expensive patterns cannot pin an action worker.

Remediates PSAAS-33137 (VULN-96707, FS-5292).

Authored by Codex for ESPM-5228.
@phantom-jacob
phantom-jacob marked this pull request as ready for review July 21, 2026 12:03

@sodle-splunk sodle-splunk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by Codex after review: non-draft, release notes use a single delimiter and match the scoped code changes, and compile/pre-commit are passing.

@sodle-splunk
sodle-splunk merged commit 382e945 into main Jul 21, 2026
11 of 19 checks passed
@sodle-splunk
sodle-splunk deleted the jacobd-codex-espm-5228-zscaler-july branch July 21, 2026 13:56
@splunk-soar-semantic-release

Copy link
Copy Markdown

🎉 This PR is included in version 3.0.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants