docs: add zsapi Base URL deprecation note and update asset config [PA… - #43
Closed
mohit-hcltech wants to merge 2 commits into
Closed
docs: add zsapi Base URL deprecation note and update asset config [PA…#43mohit-hcltech wants to merge 2 commits into
mohit-hcltech wants to merge 2 commits into
Conversation
|
Thank you for your submission! We have a total of 2 PRs open right now, and we are working hard on all of them! We will take a look as soon as we can. |
Contributor
Author
|
The required Reusable Push Workflow is failing at the checkout step with "Refusing to check out fork pull request code from a 'pull_request_target' workflow." This looks like a workflow-config/permissions issue on the base repo rather than something in this PR (docs-only change). Could a maintainer take a look or approve the run? Thanks! |
Contributor
|
@mohit-hcltech , we need to update here as well https://github.com/splunk-soar-connectors/zscaler/blob/main/zscaler_connector.py#L134 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Zscaler is deprecating
https://admin.<Zscaler Cloud Name>for Public APItraffic in September. This PR updates the Zscaler connector app documentation
to alert users and point them to the new
zsapiendpoint.Changes
users to update their asset Base URL from
admintohttps://zsapi.<Zscaler Cloud Name>.zsapiinstead ofadmin(e.g.
https://zsapi.zscaler_instance.net).Why
The
admin.<cloud>host will stop serving Public API traffic in September.Assets still pointing at it will break; updating the Base URL to
zsapikeepsthe app working. A matching note has been added to the Splunkbase app description.
Reference
Notes for reviewers
This edits
README.mddirectly. If the README is generated from the app's.jsonmanifest, please flag it and I'll move the change to the source file.