Fix broken action - zscaler_connector.py: URLs could not be submitted… - #36
Open
MrAdamBlack wants to merge 1 commit into
Open
Fix broken action - zscaler_connector.py: URLs could not be submitted…#36MrAdamBlack wants to merge 1 commit into
MrAdamBlack wants to merge 1 commit into
Conversation
… to ZScaler Custom URL Categories due to missing parameters.
|
Thank you for your submission! We will take a look as soon as we can. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… to ZScaler Custom URL Categories due to missing parameters.
Bug Fixes
Describe any bugs you've fixed in this app, and how they were fixed
Previously, URLs were added using the dbCategorizedUrls field and a generic PUT request to /api/v1/urlCategories/{category_id}. This approach failed for Custom URL Categories due to missing required parameters and incorrect endpoint usage.
The fix updates the logic to use the urls field and sends a PUT request to /api/v1/urlCategories/{category_id}?action=ADD_TO_LIST, including necessary fields like superCategory and configuredName. This aligns with ZScaler’s API expectations for modifying Custom URL Categories and restores functionality.
Manual Documentation
Have you made any changes that should be documented in manual_readme_content.md?
The following changes require documentation in manual_readme_content.md:
No new REST handlers or authentication methods were added.
No changes affecting deployment compatibility.
However, the behavior of the Add Category URL action has changed for Custom URL Categories and should be noted in the manual to reflect the updated API usage and required parameters.
Other information
This change ensures compatibility with ZScaler’s current API structure for managing Custom URL Categories.
The update improves reliability and prevents silent failures when adding URLs to user-defined categories.
Please refer to our Contribution Guide for any questions on submitting a pull request.
Thanks for contributing!