-
Notifications
You must be signed in to change notification settings - Fork 10
Sanchaga/pr 58 reviewbottest #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sanchaga-splunk
wants to merge
41
commits into
main
Choose a base branch
from
sanchaga/pr-58-reviewbottest
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
f80fe1e
Broken code
NiemySpiewak-splunk fcbdab8
PSAAS-24764: Move code to 'package' directory
9df0b89
Merge pull request #44 from arosicki/arosicki/PSAAS-24764-sdk-code-st…
NiemySpiewak-splunk 996e475
feat: Implement 'http_get' action for making GET requests
NiemySpiewak-splunk 4c86c97
important files
NiemySpiewak-splunk 607d1b7
fix: added important files
NiemySpiewak-splunk 64e13d5
PSAAS-24764 SDK code structure and test_connectivity implementation
NiemySpiewak-splunk beeb815
refactor: restructure app and improve http_get implementation
NiemySpiewak-splunk c2f20f1
Merge branch 'msankowska/PSAAS-24763-porting_HTTP_to_SDK' into msanko…
NiemySpiewak-splunk 29f79d4
refactor: Improve code architecture and modularity
NiemySpiewak-splunk a9cef95
Merge branch 'msankowska/PSAAS-24765-get-action' of github.com:splunk…
NiemySpiewak-splunk 57773a1
refactor: improve header parsing
NiemySpiewak-splunk 8e7a351
PSAAS-24765 adding GET action
NiemySpiewak-splunk eb027b5
feat: POST action
NiemySpiewak-splunk ec91888
fix: tested code - POST,GET,CONNECTIVITY,AUTH
NiemySpiewak-splunk 2699936
PSAAS-24767-POST-request
NiemySpiewak-splunk 78ca07f
feat: PUT request
NiemySpiewak-splunk 6f946c6
fix: code refactoring
NiemySpiewak-splunk a683610
PSAAS-24768-PUT request
NiemySpiewak-splunk 3253065
feat: PATCH, HEAD, OPTIONS, DELETE implemented
NiemySpiewak-splunk ea48031
small logger fix
NiemySpiewak-splunk dc56679
code refactoring
NiemySpiewak-splunk bc69378
code refactoring
NiemySpiewak-splunk 774dce1
PSAAS-25369-PATCH,HEAD,DELETE,OPTIONS-requests
NiemySpiewak-splunk f1e80c8
feat: put file and get file implementation
NiemySpiewak-splunk 12db9d5
fix: code refactoring
NiemySpiewak-splunk 58e7453
fix: body and verify_certificate not required - all tests passed
NiemySpiewak-splunk 8298817
PSAAS-25413-put_and_get_file
NiemySpiewak-splunk 516b996
fix: added descriptions
NiemySpiewak-splunk c3835d5
fix: app description
NiemySpiewak-splunk af2245d
logs added
NiemySpiewak-splunk 533d7a7
small changes
NiemySpiewak-splunk 50c1c7c
PSAAS-25399-code_refactoring
NiemySpiewak-splunk ce509a5
fix: pre commit file needs to be at top level
tapishj-splunk d588e66
fix: pre commit updates and test to get connector ci working
tapishj-splunk 4a34fae
Merge branch 'main' into msankowska/PSAAS-24763-porting_HTTP_to_SDK
tapishj-splunk f1226d6
fix: trigger workflow
tapishj-splunk 41f46f0
add input fields for public certificate and private key
NiemySpiewak-splunk 258ac45
temporary file creator
NiemySpiewak-splunk 66821ac
request_maker updated - enable certificate auth in requests
NiemySpiewak-splunk 6c58252
refactoring
NiemySpiewak-splunk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| name: Call Push Workflow | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: | ||
| - opened # When a new PR is opened | ||
| - synchronize # When a new commit is pushed to the PR branch | ||
|
|
||
| jobs: | ||
| call-push: | ||
| uses: splunk-soar-connectors/.github/.github/workflows/push.yml@tapishj/PAPP-36785-update-ci-for-sdkfied-apps | ||
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue: uses: splunk-soar-connectors/.github/.github/workflows/push.yml@tapishj/PAPP-36785-update-ci-for-sdkfied-apps — this pins CI to a personal branch that can be force-pushed or deleted at any time.
Suggested fix: Pin to a stable tag or the main branch of the shared workflow repo once the referenced branch is merged.