Implement ADB function through qemu pipe - #43
Conversation
Signed-off-by: getian <getian@xiaomi.com>
|
Splited from #42. |
|
should we add CONFIG_ADBD_QEMU_SERVER to CMakefile.txt too? @JianyuWang0623 |
Yes, and @xuxin930 has added - https://github.com/apache/nuttx-apps/pull/2426/files#diff-ad8659093e701ea8aa2f27505b482c6346472d300b077032a9d418482e36ce86R69 |
|
@spiriou Could you reivew this PR please? |
|
|
||
| ret = write(fd, cookie, sizeof(cookie) - 1); | ||
| if (ret != sizeof(cookie) - 1) { | ||
| adb_err("qemu server write error %d %d\n", ret, errno); |
There was a problem hiding this comment.
it's possible that ret is positive integer if fd is nonblocking (it should be with libuv).
https://man7.org/linux/man-pages/man2/write.2.html
Note that a successful write() may transfer fewer than count bytes.
There was a problem hiding this comment.
Get, thank you.
There was a problem hiding this comment.
it's possible that ret is positive integer if fd is nonblocking (it should be with libuv). https://man7.org/linux/man-pages/man2/write.2.html
Note that a successful write() may transfer fewer than count bytes.
Link: #47
3 participants
Summary
Add qemu pipe support for microADB.
Please enable
ADBD_QEMU_SERVERto experience this feature.More details about Kconfig, please see https://github.com/apache/nuttx-apps/pull/2688 - a497eb954e69165aa785597fa50082f74a0f718a.
Impact
New feature, enabled by
CONFIG_ADBD_QEMU_SERVER.Testing
CI