microADB: using timer to check usb hotplug event - #40
Open
Donny9 wants to merge 1 commit into
Open
Conversation
Signed-off-by: dongjiuzhu1 <dongjiuzhu1@xiaomi.com>
spiriou
reviewed
Mar 11, 2024
| int ret; | ||
| int fd; | ||
|
|
||
| ret = uv_pipe_init(uv_default_loop(), &client->read_pipe, 0); |
Owner
There was a problem hiding this comment.
it's better to use the uv loop from client instead of uv_default_loop().
spiriou
reviewed
Mar 11, 2024
Comment on lines
+32
to
+35
| #ifdef CONFIG_ADBD_USB_HOTPLUG_BYTIMER | ||
| uv_timer_t timer; | ||
| #endif | ||
| char path[0]; |
Owner
There was a problem hiding this comment.
I would prefer to handle the hotplug timer outside of the hal_uv_client_usb file. This new hotplug timer could periodically check for "/dev/adb0" file, and call adb_uv_usb_setup(adbd, "/dev/adb0") when required to setup usb port.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
microADB: using timer to check usb hotplug event
let's setup timer to check usb hotplug, and keep adbd always alive.