Partial support for GNOME 40

[realh]

This adds partial support for GNOME 40 (see #148). Some more work is needed to restore full functionality, but this at least lets you extend the panel to additional monitors and edit preferences.

Summary of changes:

• Replaced ViewSelector with SearchController
• Commented out code related to MultiMonitorsSlidingControl
• Make prefs.js compatible with GTK4

[zoharsnir]

FWIW works for me as described. Thanks realh!

[maxsaller]

Excellent! This at least restores symmetry to my multi-monitor setup!
Works are described, would be awesome to see this developed further and incorporated.

[dahjah]

This is fantastic! Super helpful. Too bad the original maintainer appears to be AFK tho...

[csedesio]

how do i install it?

[realh]

If you already have an old version remove it first. Clone my repo, then copy or make a symlink of multi-monitors-add-on@spin83 into ~/.local/share/gnome-shell/extensions. Then run gnome-extensions-enable multi-monitors-add-on@spin83 or restart the desktop.

[JayDoubleu]

I'm unable to enable this extension on Gnome 41.
Returns stateAdjustment is undefined

[PixsaOJ]

Update README on your fork please. I did whole support again, thinking I was fixing bugs in this PR. I downloaded the original one.

[floviolleau]

Thanks @realh!
Excellent work!

[Kirottu]

I have the stateAdjustment is undefined error as well on gnome wayland.

[PartyLogan]

I have removed the stateAdjustment is undefined error for gnome 42.1 wayland by adding this.stateAdjustment = 0; into the constructor. Obviously super hacky and not correct but it allows me to access the extension's settings now.

[Kirottu]

I have removed the stateAdjustment is undefined error for gnome 42.1 wayland by adding this.stateAdjustment = 0; into the constructor. Obviously super hacky and not correct but it allows me to access the extension's settings now.

How exactly did you make this change @PartyLogan? I tried adding that to the constructor() function of the MultiMonitorAddOn class and it does not resolve the error.

[Bharakuda]

I have removed the stateAdjustment is undefined error for gnome 42.1 wayland by adding this.stateAdjustment = 0; into the constructor. Obviously super hacky and not correct but it allows me to access the extension's settings now.

How exactly did you make this change @PartyLogan? I tried adding that to the constructor() function of the MultiMonitorAddOn class and it does not resolve the error.

In extension.js MultiMonitorsAddOn class, it resolved the error msg for me

[realh]

The error is non-fatal for me. In the log it shows as:

JS ERROR: Extension multi-monitors-add-on@spin83: TypeError: stateAdjustment is undefined
_init@resource:///org/gnome/shell/ui/overviewControls.js:47:9
ControlsManagerLayout@resource:///org/gnome/shell/ui/overviewControls.js:31:1
_init@/home/tony/.local/share/gnome-shell/extensions/multi-monitors-add-on@spin83/mmoverview.js:370:22
MultiMonitorsControlsManager@/home/tony/.local/share/gnome-shell/extensions/multi-monitors-add-on@spin83/mmoverview.js:360:1
_init@/home/tony/.local/share/gnome-shell/extensions/multi-monitors-add-on@spin83/mmoverview.js:624:26
MultiMonitorsOverviewActor@/home/tony/.local/share/gnome-shell/extensions/multi-monitors-add-on@spin83/mmoverview.js:591:1
MultiMonitorsOverview@/home/tony/.local/share/gnome-shell/extensions/multi-monitors-add-on@spin83/mmoverview.js:637:26
_showThumbnailsSlider@/home/tony/.local/share/gnome-shell/extensions/multi-monitors-add-on@spin83/extension.js:114:28
_relayout@/home/tony/.local/share/gnome-shell/extensions/multi-monitors-add-on@spin83/extension.js:172:9
enable@/home/tony/.local/share/gnome-shell/extensions/multi-monitors-add-on@spin83/extension.js:204:8
enable@/home/tony/.local/share/gnome-shell/extensions/multi-monitors-add-on@spin83/extension.js:280:24
_callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:181:32

I don't see how @Bharakuda's change could affect that. Unfortunately I don't know what that class in gnome-shell is supposed to do or what the extension was trying to do with it, so I can't come up with a proper fix. All I ever wanted was for the panel to appear on both monitors, which still works for me.

[Bharakuda]

The error was also non-fatal for me, I was just curious what would happen if I tried to implement that suggested fix. Nothing really changed except that I have no more of that error message stateAdjustment is undefined, when I look in extensions.
I guess it stopped complaining since stateAdjustment variable became defined as zero, but it was not my suggestion anyway but PartyLogan's.
Also to mention I am on ubuntu 21.10 having wayland disabled, and top panel is appearing on all monitors which is great :) Thanks @realh for your work!

[drmikecrowe]

@realh -- I'm still getting this with your branch:

JS ERROR: TypeError: Main.overview.searchController is undefined
 _hideThumbnailsSlider@/home/mcrowe/.local/share/gnome-shell/extensions/multi-monitors-add-on@spin83/extension.js:160:9
_relayout@/home/mcrowe/.local/share/gnome-shell/extensions/multi-monitors-add-on@spin83/extension.js:171:9
_monitorsChanged@resource:///org/gnome/shell/ui/layout.js:576:14

[bereng]

Excellent. Now I only need the Alt-tab switch of apps pane to display on all monitors as well and I'll be all set up. Thx again!

[RomanValov]

Hi @realh and folks. It would be nice if you check this ticket:

hardpixel/unite-shell#310

it's about multi monitor addon and unite extension interaction