Local dev bootstrap#97
Merged
Merged
Conversation
Three issues kept a fresh `cp .env.example .env && make up && make seed` from working out of the box: - The frontend reads NEXT_PUBLIC_DEVELOP_BACKEND_URL (and the three NEXT_PUBLIC_DEVELOP_MAPTILE_* style URLs) but nothing set them in the container, so API calls went to "undefined". Pass them through in docker-compose with sensible dev defaults (http://localhost, i.e. via nginx; empty maptile URLs — the app boots without a MapTiler key) and document them in .env.example. - The backend and celery worker could start before Postgres was ready; the entrypoint then crashed running alembic on first boot. Gate both on the db healthcheck (and redis startup) via depends_on conditions. - `make seed` and `make grant-admin` ran scripts without PYTHONPATH=/app, so imports failed inside the container.
The map components pass the MapTiler style URL straight from env vars to MapLibre; with no key configured the basemap silently rendered blank. settings.js now exports a plain OSM raster style object as the fallback, so the map renders out of the box in dev and demo environments. MapLibre accepts either a style URL or a style object, so the map components are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few miscellaneous odds and ends for cleaning up the dev workflow and the maps for local dev.