Modernization and testing of BDK#94
Merged
Merged
Conversation
- Manage Python dependencies with uv (pyproject.toml + uv.lock); drop requirements.txt. - Move backend and worker images to Python 3.12, installed via uv; keep GDAL + tippecanoe. - Update geospatial file reading to modern geopandas/pyogrio (replacing fastkml and fiona driver toggling) and SQLAlchemy 2.0 import paths. - Fix two dependency-bump regressions: werkzeug 3 password hashing and flask-jwt-extended 4.7 subject verification. - Adopt ruff for linting and formatting. - Stop auto-generating database migrations at container startup.
- pytest suite: unit tests for the geospatial readers, coverage algorithms and CSV export; API/auth smoke tests through the Flask routes; and an end-to-end test that replays real filings and asserts the pipeline output is reproduced. - docker-compose.test.yml runs the suite in the backend image against a throwaway Postgres, matching the production stack. - GitHub Actions runs ruff and pytest on every pull request.
- .env.example documenting all required configuration. - Makefile with one-command up/down/test/lint/seed/migrate. - scripts/seed.py to seed a development org, user and sample filing. - .gitignore: ignore local dev data and tool caches.
Run ruff format over files added after the initial formatting pass so ruff format --check is clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting a big cleanup of this codebase so we can better manage it going forward. Step one is adding tests, modernizing the build process and dependency management, running a linter, and cleaning up the developer environment and build process.