Avoid quadratic re-sorting of consecutive target and index nodes - #14612
Open
larsoner wants to merge 3 commits into
Open
Avoid quadratic re-sorting of consecutive target and index nodes#14612larsoner wants to merge 3 commits into
larsoner wants to merge 3 commits into
Conversation
jdillard
approved these changes
Aug 21, 2026
jdillard
left a comment
jdillard
left a comment
Member
There was a problem hiding this comment.
Nice! I feel like this change deserves a CHANGES.rst entry
Contributor
Author
|
Okay, pushed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Avoid re-sorting nodes that are already sorted. This takes a doc build for my project from 5m40s to 4m33s by taking
_reorder_index_target_nodestime from 69.4s to 2.5s.We include a
names.incwith hundreds of entries inrst_prolog. I'm going to independently mitigate in MNE by only including that file where it's needed and trim those included inrst_prologas well, but I imagine there are other projects that have these sorts of large link inclusions, and it would be nice not to penalize having too many links so heavily.References
None
AI Disclosure
Claude Fable 5 was used to diagnose the problem (py-spy on MNE-Python docs) and write the fix. I reviewed and validated the implementation.